List:Commits« Previous MessageNext Message »
From:tim Date:August 27 2007 5:46pm
Subject:bk commit into 5.1 tree (tsmith:1.2576) BUG#30648
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of tsmith. When tsmith does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-08-27 11:46:34-06:00, tsmith@stripped +1 -0
  Bug #30648: Partition handler may not initialize variable used w/ autoincrement
  
  A local variable may be used uninitialized in 
  ha_partition::get_auto_increment().  Initialize it properly.

  sql/ha_partition.cc@stripped, 2007-08-27 11:46:32-06:00, tsmith@stripped +1 -0
    Initialize first_value_part in ha_partition::get_auto_increment() with *first_value before
    it's used in the underlying table handler.  Thanks to Antony for digging up this fix.

diff -Nrup a/sql/ha_partition.cc b/sql/ha_partition.cc
--- a/sql/ha_partition.cc	2007-08-13 07:11:10 -06:00
+++ b/sql/ha_partition.cc	2007-08-27 11:46:32 -06:00
@@ -5445,6 +5445,7 @@ void ha_partition::get_auto_increment(ul
 
   for (pos=m_file, end= m_file+ m_tot_parts; pos != end ; pos++)
   {
+    first_value_part= *first_value;
     (*pos)->get_auto_increment(offset, increment, nb_desired_values,
                                &first_value_part, &nb_reserved_values_part);
     if (first_value_part == ~(ulonglong)(0)) // error in one partition
Thread
bk commit into 5.1 tree (tsmith:1.2576) BUG#30648tim27 Aug