MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Hakan Kuecuekyilmaz Date:August 22 2007 10:16am
Subject:bk commit into 6.0-falcon tree (hakank:1.2685) BUG#28006
View as plain text  
Below is the list of changes that have just been committed into a local
6.0-falcon repository of hakan. When hakan does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-08-22 12:16:02+02:00, hakank@stripped +3 -0
  Added test for Bug #28006.

  mysql-test/r/falcon_bug_28006.result@stripped, 2007-08-22 12:16:00+02:00, hakank@stripped +33 -0
    New BitKeeper file ``mysql-test/r/falcon_bug_28006.result''

  mysql-test/r/falcon_bug_28006.result@stripped, 2007-08-22 12:16:00+02:00, hakank@stripped +0 -0

  mysql-test/t/disabled.def@stripped, 2007-08-22 12:16:00+02:00, hakank@stripped +1 -0
    Disabled failing test.

  mysql-test/t/falcon_bug_28006.test@stripped, 2007-08-22 12:16:00+02:00, hakank@stripped +62 -0
    New BitKeeper file ``mysql-test/t/falcon_bug_28006.test''

  mysql-test/t/falcon_bug_28006.test@stripped, 2007-08-22 12:16:00+02:00, hakank@stripped +0 -0

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	hakank
# Host:	lu0011.wdf.sap.corp
# Root:	/home/hakan/work/mysql/mysql-5.1-falcon
--- New file ---
+++ mysql-test/r/falcon_bug_28006.result	07/08/22 12:16:00
*** Bug #28006 ***
SET @@storage_engine = 'Falcon';
DROP TABLE IF EXISTS t1;
SET @@tx_isolation = 'REPEATABLE-READ';
SET @@autocommit = 0;
CREATE TABLE t1 (a int);
INSERT INTO t1 VALUES (1);
COMMIT;
# Establish connection conn1
SET storage_engine = 'Falcon';
SET @@tx_isolation = 'REPEATABLE-READ';
SET @@autocommit = 0;
# Switch to connection default
BEGIN;
SELECT * FROM t1;
a
1
# Switch to connection conn1
ALTER TABLE t1 ADD COLUMN b int;
ALTER TABLE t1 DROP COLUMN a;
# Switch to connection default
SELECT * FROM t1;
a
1
COMMIT;
SELECT count(*) FROM t1;
count(*)
1
COMMIT;
# Switch to connection conn1
COMMIT;
# Switch to connection default
DROP TABLE t1;

--- New file ---
+++ mysql-test/t/falcon_bug_28006.test	07/08/22 12:16:00
#
# Bug #28006: Falcon: isolation failed after alter
# Note: related to Bug#15491 "ALTER TABLE violates REPEATABLE READ"
#
--echo *** Bug #28006 ***

# ----------------------------------------------------- #
# --- Initialisation                                --- #
# ----------------------------------------------------- #
let $engine = 'Falcon';
eval SET @@storage_engine = $engine;

--disable_warnings
DROP TABLE IF EXISTS t1;
--enable_warnings

SET @@tx_isolation = 'REPEATABLE-READ';
SET @@autocommit = 0;
CREATE TABLE t1 (a int);
INSERT INTO t1 VALUES (1);
COMMIT;

--echo # Establish connection conn1
connect (conn1,localhost,root,,);
eval SET storage_engine = $engine;
SET @@tx_isolation = 'REPEATABLE-READ';
SET @@autocommit = 0;

# ----------------------------------------------------- #
# --- Test                                          --- #
# ----------------------------------------------------- #
--echo # Switch to connection default
connection default;
BEGIN;
SELECT * FROM t1;

--echo # Switch to connection conn1
connection conn1;
ALTER TABLE t1 ADD COLUMN b int;
ALTER TABLE t1 DROP COLUMN a;

--echo # Switch to connection default
connection default;
SELECT * FROM t1;
COMMIT;

# ----------------------------------------------------- #
# --- Check                                         --- #
# ----------------------------------------------------- #
SELECT count(*) FROM t1;
COMMIT;

# ----------------------------------------------------- #
# --- Final cleanup                                 --- #
# ----------------------------------------------------- #
--echo # Switch to connection conn1
connection conn1;
COMMIT;
--echo # Switch to connection default
connection default;
disconnect conn1;
DROP TABLE t1;


--- 1.340/mysql-test/t/disabled.def	2007-08-21 18:02:07 +02:00
+++ 1.341/mysql-test/t/disabled.def	2007-08-22 12:16:00 +02:00
@@ -70,6 +70,7 @@
 #falcon_bug_26607    : Bug#26607 2007-02-23 hakank Currently failing
 falcon_bug_27426    : Bug#27426 2007-03-27 hakank Currently failing
 falcon_bug_27997    : Bug#27997 2007-04-21 hakank Currently failing
+falcon_bug_28006    : Bug#28006 2007-08-22 hakank Won't fix, see also Bug#15491
 falcon_bug_28026    : Bug#28026 2007-04-25 hakank Currently failing
 falcon_bug_29151    : Bug#29151 2007-08-01 hakank Currently failing
 falcon_bug_29246    : Bug#29246 2007-06-21 hakank Currently failing
Thread
bk commit into 6.0-falcon tree (hakank:1.2685) BUG#28006Hakan Kuecuekyilmaz22 Aug