MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Lars Thalmann Date:February 27 2006 9:14pm
Subject:bk commit into 5.1 tree (lars:1.2168) BUG#17752
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of lthalmann. When lthalmann does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2168 06/02/27 22:14:46 lars@stripped +1 -0
  BUG#17752: Non-allocated memory caused core in rpl_multi_engine test

  sql/log_event.cc
    1.208 06/02/27 22:14:38 lars@stripped +0 -10
    Removed optimization that is no longer valid

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	lars
# Host:	dl145h.mysql.com
# Root:	/users/lthalmann/bk/mysql-5.1-release-bug13418.2

--- 1.207/sql/log_event.cc	2006-02-25 23:55:15 +01:00
+++ 1.208/sql/log_event.cc	2006-02-27 22:14:38 +01:00
@@ -6685,16 +6685,6 @@
 {
   DBUG_ASSERT(m_memory == NULL);
 
-  if ((table->file->table_flags() & HA_PRIMARY_KEY_ALLOW_RANDOM_ACCESS) &&
-      table->s->primary_key < MAX_KEY)
-  {
-    /*
-      We don't need to allocate any memory for m_after_image and
-      m_key since they are not used.
-    */
-    return 0;
-  }
-
   int error= 0;
 
   if (table->s->keys > 0)
Thread
bk commit into 5.1 tree (lars:1.2168) BUG#17752Lars Thalmann27 Feb