MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:msvensson Date:February 24 2006 4:10pm
Subject:bk commit into 5.1 tree (msvensson:1.2162) BUG#17443
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2162 06/02/24 17:10:40 msvensson@neptunus.(none) +4 -0
  Bug #17443  	mysqldump test failure

  mysql-test/t/mysqldump.test
    1.83 06/02/24 17:10:35 msvensson@neptunus.(none) +0 -2
    Remove the disable_parsing on tests for --use-threads to mysqlimport

  mysql-test/t/disabled.def
    1.84 06/02/24 17:10:35 msvensson@neptunus.(none) +0 -1
    Remove disable of mysqldump

  mysql-test/r/mysqldump.result
    1.94 06/02/24 17:10:35 msvensson@neptunus.(none) +30 -0
    Update result 

  client/mysqlimport.c
    1.69 06/02/24 17:10:34 msvensson@neptunus.(none) +0 -2
    Remove disabled --use-threads option 

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	neptunus.(none)
# Root:	/home/msvensson/mysql/mysql-5.1-release

--- 1.68/client/mysqlimport.c	2006-02-19 23:46:53 +01:00
+++ 1.69/client/mysqlimport.c	2006-02-24 17:10:34 +01:00
@@ -145,13 +145,11 @@
    (gptr*) &opt_mysql_unix_port, (gptr*) &opt_mysql_unix_port, 0, GET_STR,
    REQUIRED_ARG, 0, 0, 0, 0, 0, 0},
 #include <sslopt-longopts.h>
-#if 0
   {"use-threads", OPT_USE_THREADS,
    "Load files in parallel. The argument is the number "
    "of threads to use for loading data.",
    (gptr*) &opt_use_threads, (gptr*) &opt_use_threads, 0, 
    GET_UINT, REQUIRED_ARG, 0, 0, 0, 0, 0, 0},
-#endif
 #ifndef DONT_ALLOW_USER_CHANGE
   {"user", 'u', "User for login if not current user.", (gptr*) &current_user,
    (gptr*) &current_user, 0, GET_STR, REQUIRED_ARG, 0, 0, 0, 0, 0, 0},

--- 1.83/mysql-test/t/disabled.def	2006-02-21 13:07:19 +01:00
+++ 1.84/mysql-test/t/disabled.def	2006-02-24 17:10:35 +01:00
@@ -36,4 +36,3 @@
 rpl_until               : Unstable test case, bug#15886
 sp-goto                 : GOTO is currently is disabled - will be fixed in the future
 rpl_ndb_log             : results are not deterministic
-mysqldump               : Bug#17443 mysqlimport --use-threads=5 gives crashes

--- 1.93/mysql-test/r/mysqldump.result	2006-02-17 18:19:24 +01:00
+++ 1.94/mysql-test/r/mysqldump.result	2006-02-24 17:10:35 +01:00
@@ -2650,3 +2650,33 @@
 
 DROP TRIGGER tr1;
 DROP TABLE t1;
+create table t1 (a text , b text);
+create table t2 (a text , b text);
+insert t1 values ("Duck, Duck", "goose");
+insert t1 values ("Duck, Duck", "pidgeon");
+insert t2 values ("We the people", "in order to perform");
+insert t2 values ("a more perfect", "union");
+select * from t1;
+a	b
+Duck, Duck	goose
+Duck, Duck	pidgeon
+select * from t2;
+a	b
+We the people	in order to perform
+a more perfect	union
+test.t1: Records: 2  Deleted: 0  Skipped: 0  Warnings: 0
+test.t2: Records: 2  Deleted: 0  Skipped: 0  Warnings: 0
+select * from t1;
+a	b
+Duck, Duck	goose
+Duck, Duck	pidgeon
+Duck, Duck	goose
+Duck, Duck	pidgeon
+select * from t2;
+a	b
+We the people	in order to perform
+a more perfect	union
+We the people	in order to perform
+a more perfect	union
+drop table t1;
+drop table t2;

--- 1.82/mysql-test/t/mysqldump.test	2006-02-17 18:19:24 +01:00
+++ 1.83/mysql-test/t/mysqldump.test	2006-02-24 17:10:35 +01:00
@@ -1049,7 +1049,6 @@
 DROP TRIGGER tr1;
 DROP TABLE t1;
 
---disable_parsing
 #
 # Added for use-thread option
 #
@@ -1073,4 +1072,3 @@
 
 drop table t1;
 drop table t2;
---enable_parsing
Thread
bk commit into 5.1 tree (msvensson:1.2162) BUG#17443msvensson24 Feb