MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:holyfoot Date:June 25 2007 11:40am
Subject:bk commit into 5.0 tree (holyfoot:1.2496) BUG#29247
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of hf. When hf does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-06-25 16:40:29+05:00, holyfoot@stripped +1 -0
  Bug #29247 Double free in libmysqlclient_r when mysql restarted.
  
  If one sets MYSQL_READ_DEFAULTS_FILE and MYSQL_READ_DEFAULT_GROUP options
  after mysql_real_connect() called with that MYSQL instance,
  these options will affect next mysql_reconnect then.
  As we use a copy of the original MYSQL object inside mysql_reconnect,
  and mysql_real_connect frees options.my_cnf_file and _group strings,
  we will free these twice when we execute mysql_reconnect with the
  same MYSQL for the second time.
  
  I don't think we should ever read defaults files handling mysql_reconnect.
  So i just set them to 0 for the temporary MYSQL object there/

  sql-common/client.c@stripped, 2007-06-25 16:40:27+05:00, holyfoot@stripped +1 -0
    Bug #29247 Double free in libmysqlclient_r when mysql restarted.
    
    we don't need mysql_real_connect to reread defaults file in this
    case, so set related parameters to zero

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	holyfoot
# Host:	hfmain.(none)
# Root:	/home/hf/work/29247/my50-29247

--- 1.114/sql-common/client.c	2007-06-25 16:40:32 +05:00
+++ 1.115/sql-common/client.c	2007-06-25 16:40:32 +05:00
@@ -2451,6 +2451,7 @@ my_bool mysql_reconnect(MYSQL *mysql)
   }
   mysql_init(&tmp_mysql);
   tmp_mysql.options= mysql->options;
+  tmp_mysql.options.my_cnf_file= tmp_mysql.options.my_cnf_group= 0;
   tmp_mysql.rpl_pivot= mysql->rpl_pivot;
   
   if (!mysql_real_connect(&tmp_mysql,mysql->host,mysql->user,mysql->passwd,
Thread
bk commit into 5.0 tree (holyfoot:1.2496) BUG#29247holyfoot25 Jun
  • Re: bk commit into 5.0 tree (holyfoot:1.2496) BUG#29247Sergei Golubchik28 Jun