MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:kgeorge Date:June 8 2007 10:42am
Subject:bk commit into 5.0 tree (gkodinov:1.2523) BUG#28754
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of kgeorge. When kgeorge does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-06-08 13:42:10+03:00, gkodinov@stripped +1 -0
  Bug #28754: RPM builds differ from tar.gz in "ALTER ... RENAME" on views
   When constructing the path to the original .frm file ALTER .. RENAME
   was unnecessary (and incorrectly) lowercasing the whole path when not 
   on a case-insensitive filesystem.
   This path should not be modified because of lower_case_table_names
   as it is already in the correct case according to that setting.
   Fixed by removing the lowercasing.
   Unfortunately testing this would require running the tests on a case
   sensitive filesystem in a directory that has uppercase letters.
   This cannot be guaranteed in all setups so no test case added.

  sql/sql_table.cc@stripped, 2007-06-08 13:42:09+03:00, gkodinov@stripped +0 -2
    Bug #28754: don't downcase the .frm path

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	gkodinov
# Host:	magare.gmz
# Root:	/home/kgeorge/mysql/work/B28754-5.0-opt

--- 1.347/sql/sql_table.cc	2007-06-02 01:42:04 +03:00
+++ 1.348/sql/sql_table.cc	2007-06-08 13:42:09 +03:00
@@ -3101,8 +3101,6 @@ bool mysql_alter_table(THD *thd,char *ne
 						   alter_info->tablespace_op));
   sprintf(new_name_buff,"%s/%s/%s%s",mysql_data_home, db, table_name, reg_ext);
   unpack_filename(new_name_buff, new_name_buff);
-  if (lower_case_table_names != 2)
-    my_casedn_str(files_charset_info, new_name_buff);
   frm_type= mysql_frm_type(thd, new_name_buff, &table_type);
   /* Rename a view */
   if (frm_type == FRMTYPE_VIEW && !(alter_info->flags & ~ALTER_RENAME))
Thread
bk commit into 5.0 tree (gkodinov:1.2523) BUG#28754kgeorge8 Jun