MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:msvensson Date:February 28 2007 3:37pm
Subject:bk commit into 4.1 tree (msvensson:1.2612) BUG#24878
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-02-28 16:37:50+01:00, msvensson@stripped +1 -0
  Bug#24878 mysql server doesn't log incident time in "mysqld got signal 11" error messages
   - Add printout of current time when mysqld is killed by an
     unhandled signal

  sql/mysqld.cc@stripped, 2007-02-28 16:37:50+01:00, msvensson@stripped +10 -1
    Add printout of current time before the "mysqld got signal %d" message
    Hopefully we don't crash in the calls to 'time' or 'localtime_r'
    but if that should start to happen we can move the printout of
    time further down. At least it's now below the check for segfault
    inside of segfault handler. 

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	pilot.blaudden
# Root:	/home/msvensson/mysql/bug24878/my41-bug24878

--- 1.625/sql/mysqld.cc	2007-02-06 14:44:04 +01:00
+++ 1.626/sql/mysqld.cc	2007-02-28 16:37:50 +01:00
@@ -1933,7 +1933,10 @@ static void check_data_home(const char *
 
 extern "C" sig_handler handle_segfault(int sig)
 {
+  time_t curr_time;
+  struct tm tm;
   THD *thd=current_thd;
+
   /*
     Strictly speaking, one needs a mutex here
     but since we have got SIGSEGV already, things are a mess
@@ -1947,11 +1950,17 @@ extern "C" sig_handler handle_segfault(i
   }
 
   segfaulted = 1;
+
+  curr_time= time(NULL);
+  localtime_r(&curr_time, &tm);
+
   fprintf(stderr,"\
-mysqld got signal %d;\n\
+%02d%02d%02d %2d:%02d:%02d - mysqld got signal %d;\n\
 This could be because you hit a bug. It is also possible that this binary\n\
 or one of the libraries it was linked against is corrupt, improperly built,\n\
 or misconfigured. This error can also be caused by malfunctioning hardware.\n",
+          tm.tm_year % 100, tm.tm_mon+1, tm.tm_mday,
+          tm.tm_hour, tm.tm_min, tm.tm_sec,
 	  sig);
   fprintf(stderr, "\
 We will try our best to scrape up some info that will hopefully help diagnose\n\
Thread
bk commit into 4.1 tree (msvensson:1.2612) BUG#24878msvensson28 Feb