MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Stewart Smith Date:February 14 2007 4:55am
Subject:bk commit into 5.0 tree (stewart:1.2411) BUG#26357
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of stewart. When stewart does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-02-14 15:55:08+11:00, stewart@willster.(none) +4 -0
  BUG#26357  	remove unused GSN_STATISTICS_REQ and CONF
  
  remove GSN_STATISTICS_REQ and CONF
  
  These are unused and have been since BK import. not needed.

  ndb/include/kernel/GlobalSignalNumbers.h@stripped, 2007-02-14 15:55:06+11:00, stewart@willster.(none) +2 -2
    remove STATISTICS_REQ and CONF

  ndb/src/common/debugger/signaldata/SignalNames.cpp@stripped, 2007-02-14 15:55:06+11:00, stewart@willster.(none) +1 -3
    remove signal names for STATISTICS_REQ and CONF (unused)

  ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp@stripped, 2007-02-14 15:55:06+11:00, stewart@willster.(none) +0 -19
    remove unused STATISTICS signals

  ndb/src/kernel/blocks/cmvmi/Cmvmi.hpp@stripped, 2007-02-14 15:55:06+11:00, stewart@willster.(none) +0 -1
    remove unused STATISTICS signals

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	stewart
# Host:	willster.(none)
# Root:	/home/stewart/Documents/MySQL/5.0/ndb-work

--- 1.18/ndb/include/kernel/GlobalSignalNumbers.h	2006-12-24 06:04:08 +11:00
+++ 1.19/ndb/include/kernel/GlobalSignalNumbers.h	2007-02-14 15:55:06 +11:00
@@ -540,13 +540,13 @@
 #define GSN_ABORT_ALL_REF               446
 #define GSN_ABORT_ALL_CONF              447
 
-#define GSN_STATISTICS_REQ              448
+/* 448 unused - formerly GSN_STATISTICS_REQ */
 #define GSN_STOP_ORD                    449
 #define GSN_TAMPER_ORD                  450
 #define GSN_SET_VAR_REQ                 451
 #define GSN_SET_VAR_CONF                452
 #define GSN_SET_VAR_REF                 453
-#define GSN_STATISTICS_CONF             454
+/* 454 unused - formerly GSN_STATISTICS_CONF */
 
 #define GSN_START_ORD                   455
 /* 457 unused */

--- 1.11/ndb/src/common/debugger/signaldata/SignalNames.cpp	2006-12-24 06:04:12 +11:00
+++ 1.12/ndb/src/common/debugger/signaldata/SignalNames.cpp	2007-02-14 15:55:06 +11:00
@@ -380,15 +380,13 @@
   ,{ GSN_TUP_WRITELOG_REQ,       "TUP_WRITELOG_REQ" }
   ,{ GSN_LQH_WRITELOG_REQ,       "LQH_WRITELOG_REQ" }
 
-  ,{ GSN_STATISTICS_REQ,         "STATISTICS_REQ" }
   ,{ GSN_START_ORD,              "START_ORD" }
   ,{ GSN_STOP_ORD,               "STOP_ORD" }
   ,{ GSN_TAMPER_ORD,             "TAMPER_ORD" }
   ,{ GSN_SET_VAR_REQ,            "SET_VAR_REQ" }
   ,{ GSN_SET_VAR_CONF,           "SET_VAR_CONF" }
   ,{ GSN_SET_VAR_REF,            "SET_VAR_REF" }
-  ,{ GSN_STATISTICS_CONF,        "STATISTICS_CONF" }
-  
+
   ,{ GSN_EVENT_SUBSCRIBE_REQ,    "EVENT_SUBSCRIBE_REQ" }
   ,{ GSN_EVENT_SUBSCRIBE_CONF,   "EVENT_SUBSCRIBE_CONF" }
   ,{ GSN_EVENT_SUBSCRIBE_REF,    "EVENT_SUBSCRIBE_REF" }

--- 1.31/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp	2007-02-14 15:51:14 +11:00
+++ 1.32/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp	2007-02-14 15:55:06 +11:00
@@ -77,7 +77,6 @@
   addRecSignal(GSN_OPEN_COMREQ,  &Cmvmi::execOPEN_COMREQ);
   addRecSignal(GSN_TEST_ORD,  &Cmvmi::execTEST_ORD);
 
-  addRecSignal(GSN_STATISTICS_REQ,  &Cmvmi::execSTATISTICS_REQ);
   addRecSignal(GSN_TAMPER_ORD,  &Cmvmi::execTAMPER_ORD);
   addRecSignal(GSN_SET_VAR_REQ,  &Cmvmi::execSET_VAR_REQ);
   addRecSignal(GSN_SET_VAR_CONF,  &Cmvmi::execSET_VAR_CONF);
@@ -702,24 +701,6 @@
 
 #endif
 }
-
-void Cmvmi::execSTATISTICS_REQ(Signal* signal) 
-{
-  // TODO Note ! This is only a test implementation...
-
-  static int stat1 = 0;
-  jamEntry();
-
-  //ndbout << "data 1: " << signal->theData[1];
-
-  int x = signal->theData[0];
-  stat1++;
-  signal->theData[0] = stat1;
-  sendSignal(x, GSN_STATISTICS_CONF, signal, 7, JBB);
-
-}//execSTATISTICS_REQ()
-
-
 
 void Cmvmi::execSTOP_ORD(Signal* signal) 
 {

--- 1.5/ndb/src/kernel/blocks/cmvmi/Cmvmi.hpp	2006-12-24 06:04:14 +11:00
+++ 1.6/ndb/src/kernel/blocks/cmvmi/Cmvmi.hpp	2007-02-14 15:55:06 +11:00
@@ -55,7 +55,6 @@
   void execSIZEALT_ACK(Signal* signal);
   void execTEST_ORD(Signal* signal);
 
-  void execSTATISTICS_REQ(Signal* signal);
   void execSTOP_ORD(Signal* signal);
   void execSTART_ORD(Signal* signal);
   void execTAMPER_ORD(Signal* signal);
Thread
bk commit into 5.0 tree (stewart:1.2411) BUG#26357Stewart Smith14 Feb