MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:holyfoot Date:February 12 2007 11:41am
Subject:bk commit into 5.0 tree (holyfoot:1.2400) BUG#20691
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of hf. When hf does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-02-12 15:41:36+04:00, holyfoot@stripped +5 -0
  bug #20691 (INSERT (DEFAULT) may insert garbage with NO DEFAULT NOT NULL field)
  
  Some fields (GEOMETRY first of all) can't be handled properly in this
  case at all. So we return an error in this case

  mysql-test/r/default.result@stripped, 2007-02-12 15:41:34+04:00, holyfoot@stripped +11 -1
    result fixed

  mysql-test/r/gis.result@stripped, 2007-02-12 15:41:34+04:00, holyfoot@stripped +4 -0
    result fixed

  mysql-test/t/default.test@stripped, 2007-02-12 15:41:34+04:00, holyfoot@stripped +8 -1
    VIEW test added

  mysql-test/t/gis.test@stripped, 2007-02-12 15:41:34+04:00, holyfoot@stripped +9 -0
    testcase added

  sql/item.cc@stripped, 2007-02-12 15:41:34+04:00, holyfoot@stripped +7 -1
    set_defaults() changed with the 'reset()'

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	holyfoot
# Host:	hfmain.(none)
# Root:	/home/hf/work/20691/my50-20691

--- 1.252/sql/item.cc	2007-02-12 15:41:40 +04:00
+++ 1.253/sql/item.cc	2007-02-12 15:41:40 +04:00
@@ -5505,6 +5505,13 @@ int Item_default_value::save_in_field(Fi
   {
     if (field_arg->flags & NO_DEFAULT_VALUE_FLAG)
     {
+      if (field_arg->reset())
+      {
+        my_message(ER_CANT_CREATE_GEOMETRY_OBJECT,
+                   ER(ER_CANT_CREATE_GEOMETRY_OBJECT), MYF(0));
+        return -1;
+      }
+
       if (context->error_processor == &view_error_processor)
       {
         TABLE_LIST *view= cached_table->top_table();
@@ -5523,7 +5530,6 @@ int Item_default_value::save_in_field(Fi
                             ER(ER_NO_DEFAULT_FOR_FIELD),
                             field_arg->field_name);
       }
-      field_arg->set_default();
       return 1;
     }
     field_arg->set_default();

--- 1.38/mysql-test/r/gis.result	2007-02-12 15:41:40 +04:00
+++ 1.39/mysql-test/r/gis.result	2007-02-12 15:41:40 +04:00
@@ -717,3 +717,7 @@ desc t1;
 Field	Type	Null	Key	Default	Extra
 GeomFromText('point(1 1)')	geometry	NO			
 drop table t1;
+create table t1 (g geometry not null);
+insert into t1 values(default);
+ERROR 22003: Cannot get geometry object from data you send to the GEOMETRY field
+drop table t1;

--- 1.31/mysql-test/t/gis.test	2007-02-12 15:41:40 +04:00
+++ 1.32/mysql-test/t/gis.test	2007-02-12 15:41:40 +04:00
@@ -428,3 +428,12 @@ drop table t1;
 create table t1 select GeomFromText('point(1 1)');
 desc t1;
 drop table t1;
+
+#
+# Bug #20691 (DEFAULT over NOT NULL field)
+#
+create table t1 (g geometry not null);
+--error ER_CANT_CREATE_GEOMETRY_OBJECT
+insert into t1 values(default);
+drop table t1;
+

--- 1.4/mysql-test/r/default.result	2007-02-12 15:41:40 +04:00
+++ 1.5/mysql-test/r/default.result	2007-02-12 15:41:40 +04:00
@@ -193,6 +193,16 @@ a	b	c	d	e	f	g	h	i	x
 two	large	00:00:05	0007-01-01	11	13	17	0019-01-01 00:00:00	23	1
 	small	00:00:00	0000-00-00	0			0000-00-00 00:00:00	0	2
 two	large	00:00:05	0007-01-01	11	13	17	0019-01-01 00:00:00	23	3
-	small	00:00:00	0000-00-00	0			0000-00-00 00:00:00	0	4
+		00:00:00	0000-00-00	0			0000-00-00 00:00:00	0	4
 drop table bug20691;
+create table t1 (id int not null);
+insert into t1 values(default);
+Warnings:
+Warning	1364	Field 'id' doesn't have a default value
+create view v1 (c) as select id from t1;
+insert into t1 values(default);
+Warnings:
+Warning	1364	Field 'id' doesn't have a default value
+drop view v1;
+drop table t1;
 End of 5.0 tests.

--- 1.5/mysql-test/t/default.test	2007-02-12 15:41:40 +04:00
+++ 1.6/mysql-test/t/default.test	2007-02-12 15:41:40 +04:00
@@ -137,6 +137,13 @@ insert into bug20691 values (DEFAULT, DE
 select * from bug20691 order by x asc;
 drop table bug20691;
 
-###
+create table t1 (id int not null);
+insert into t1 values(default);
+
+create view v1 (c) as select id from t1;
+insert into t1 values(default);
+drop view v1;
+drop table t1;
+
 --echo End of 5.0 tests.
 
Thread
bk commit into 5.0 tree (holyfoot:1.2400) BUG#20691holyfoot12 Feb