MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:lzhou Date:December 15 2006 5:49pm
Subject:bk commit into 5.1 tree (lzhou:1.2342) BUG#22261
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of zhl. When zhl does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-12-15 17:49:13+00:00, lzhou@stripped +2 -0
  BUG#22261 remove global variable global_mgmt_server_check from ClusterMgr

  storage/ndb/src/mgmsrv/main.cpp@stripped, 2006-12-15 17:49:07+00:00, lzhou@stripped +0 -4
    Remove global variable global_mgmt_server_check

  storage/ndb/src/ndbapi/ClusterMgr.cpp@stripped, 2006-12-15 17:49:07+00:00, lzhou@stripped +1 -3
    Change another method to test whether the node is mgmsrv or not

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	lzhou
# Host:	dev3-63.dev.cn.tlan
# Root:	/home/zhl/mysql/mysql-5.1/bug22261

--- 1.51/storage/ndb/src/mgmsrv/main.cpp	2006-12-15 17:49:29 +00:00
+++ 1.52/storage/ndb/src/mgmsrv/main.cpp	2006-12-15 17:49:29 +00:00
@@ -132,8 +132,6 @@
 bool g_RestartServer;
 extern EventLogger g_eventLogger;
 
-extern int global_mgmt_server_check;
-
 enum ndb_mgmd_options {
   OPT_INTERACTIVE = NDB_STD_OPTIONS_LAST,
   OPT_NO_NODEID_CHECKS,
@@ -207,8 +205,6 @@
 
 start:
   glob= new MgmGlobals;
-
-  global_mgmt_server_check = 1;
 
   if (opt_interactive ||
       opt_non_interactive ||

--- 1.31/storage/ndb/src/ndbapi/ClusterMgr.cpp	2006-12-15 17:49:29 +00:00
+++ 1.32/storage/ndb/src/ndbapi/ClusterMgr.cpp	2006-12-15 17:49:29 +00:00
@@ -361,8 +361,6 @@
   theFacade.sendSignalUnCond(&signal, nodeId);
 }
 
-int global_mgmt_server_check = 0; // set to one in mgmtsrvr main;
-
 void
 ClusterMgr::execAPI_REGCONF(const Uint32 * theData){
   const ApiRegConf * const apiRegConf = (ApiRegConf *)&theData[0];
@@ -380,7 +378,7 @@
 
   if(node.m_info.m_version != apiRegConf->version){
     node.m_info.m_version = apiRegConf->version;
-    if (global_mgmt_server_check == 1)
+    if(theNodes[theFacade.ownId()].m_info.m_type == NodeInfo::MGM)
       node.compatible = ndbCompatible_mgmt_ndb(NDB_VERSION,
 					       node.m_info.m_version);
     else
Thread
bk commit into 5.1 tree (lzhou:1.2342) BUG#22261lzhou15 Dec