List:Commits« Previous MessageNext Message »
From:Bjorn Munch Date:December 16 2010 2:25pm
Subject:Re: bzr commit into mysql-5.5-mtr branch (bjorn.munch:3128)
View as plain text  
On 16/12 15.01, Sergei Golubchik wrote:
> Hi, Bjorn!
> On Dec 16, Bjorn Munch wrote:
> > #At file:///home/bm136801/my/genplug-55/ based on
> revid:bjorn.munch@stripped
> > 
> >  3128 Bjorn Munch	2010-12-16
> >       Bug #58841 Generalise handling of plugins in MTR script
> >       Put descriptions of plugins into a separate file read by MTR
> >       MTR itself has generalised code to read this and set env. variables
> >       Removed the *SO variables, updated some tests accordingly
> You may want to consider using the approach I took in mariadb tree -
> plugins are found automatically and symlinked (or copied) into var/plugins.
> For every plugin PLUGINNAME_SO is set to the plugin name. No separate
> configuration file is needed.

Yes i saw that, it came just before my vacation so I didn't get around
to looking more into it. This was based on 5.1 and I'm reluctant to
introduce new features in 5.1 especially now that 5.5 is out, but
that's not the main point.

Your approach would require mtr to copy all plugins (on Windows), even
for running one test as it cannot know which might be needed. This
adds to the setup time.

It also changes the system being tested, something I try to avoid as
much as possible. Otherwise some subtle bug might slip because it
doesn't materialize in the test environment. I don't know about any
such issue with plugins, it's the principle.

I'm also going to commit an extention to this fix soon. I guess you'll
see that too when it comes. :-)

> The main benefit - one can load more than one plugin at once, as they
> all are under the same plugin-dir.

Yes I know. So far I haven't seen any requests for allowing that.

> If you'd like I can contribute this mtr change under sca.
> Regards,
> Sergei
> other my mtr extensions that you may be interested in include
> * support for files
> * extending my.cnf templating
> * support for .opt files (e.g. include/have_innodb.opt, etc)

Thanks, maybe some of what you have might be interesting.

- Bjorn
bzr commit into mysql-5.5-mtr branch (bjorn.munch:3128) Bug#58841Bjorn Munch16 Dec
  • Re: bzr commit into mysql-5.5-mtr branch (bjorn.munch:3128)Bug#58841Sergei Golubchik16 Dec
    • Re: bzr commit into mysql-5.5-mtr branch (bjorn.munch:3128)Bug#58841Bjorn Munch16 Dec