Re: bzr commit into mysql-5.1-bugteam branch (Alexey.Kopytov:3514) Bug#56709

[Davi Arnaut]

On 9/30/10 9:36 AM, Sergei Golubchik wrote:
> Hi, Davi!
>
> On Sep 30, Davi Arnaut wrote:
>> On 9/30/10 8:33 AM, Tor Didriksen wrote:
>>> On Fri, Sep 24, 2010 at 11:20 AM, Alexey Kopytov
>>>>>
>>>>>   I personally think of bzero() as a convenient alias for the most
>>>>>   commonly used form of memset(). In other words, even if bzero()
>>>>>   did not exist, it should have been created. And we actually do
>>>>>   something like that in m_string.h:
>>>>>
>>>>>   #if !defined(bzero)&&   !defined(HAVE_BZERO)
>>>>>   # define bzero(A,B)             memset((A),0,(B))
>>>>>   #endif
>>>
>>> Time for another update of the style guide I guess,
>>> we shouldn't be recommending functions which are deprecated.
>>
>> Definitely. bzero is a officially deprecated function and we never
>> actually use it because it depends on some BSD defines that we never
>> set.
>
> So, Kaamos is right after all :)
>
> Coding style does not recommend a deprecated function, furthermore this
> deprecated function was never used. bzero() is just a convenience macro,
> and should be fine as such. The fact that libc has deprecated a function
> does not apply to MySQL internal macro that happen to have the same
> name :)
>

Yes and the same applies for the other BSD variants (bmp, etc). For 
bzero, I plan to make it even more clear in the context of Bug#55721, 
but I aiming to eventually get rid of it entirely.

Regards,

Davi