On 09/ 8/10 08:08 PM, Sergei Golubchik wrote:
> And how about changing DbugVfprintf() function to use my_vsnprintf()
> which has the NULL check built it ?
> DbugVfprintf was introduced for the sole purpose of using my_vsnprintf
> in dbug - but later changed to use vsnprintf() with the comment
> /* Do not use my_vsnprintf, it does not support "%g". */
> Now guess what - in 5.5 my_vsnprintf() supports %g as far as I can see,
> so dbug can safely use my_vsnprintf again. And pass NULL for %s, and
> use %p format specifier, and so on.
Thanks for your suggestion. I have committed a new patch for this change:
Tor discovered that %i was not supported in my_vsnprintf() and was used
a few places in our code. So this patch also extends my_vsnprintf() to
support %i in the format string.