MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:tim Date:August 23 2006 9:37pm
Subject:bk commit into 4.1 tree (tsmith:1.2536) BUG#20402
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of tim. When tim does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-08-23 15:37:54-06:00, tsmith@stripped +2 -0
  Bug #20402: DROP USER failure logged as ERROR rather than WARNING
  
  Remove some sql_print_error() calls which were triggered by user error (i.e., not server-level events at all).
  
  Also, convert an sql_print_error -> sql_print_information for a non-error server event.

  sql/slave.cc@stripped, 2006-08-23 15:37:52-06:00, tsmith@stripped +1 -1
    Change sql_print_error to sql_print_information for non-error status message.

  sql/sql_acl.cc@stripped, 2006-08-23 15:37:52-06:00, tsmith@stripped +0 -15
    Remove sql_print_error calls for events which are not server errors

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	tsmith
# Host:	siva.hindu.god
# Root:	/usr/home/tim/m/bk/b20536-41

--- 1.279/sql/slave.cc	2006-08-23 15:37:59 -06:00
+++ 1.280/sql/slave.cc	2006-08-23 15:37:59 -06:00
@@ -2946,7 +2946,7 @@ static int exec_relay_log_event(THD* thd
       rli->is_until_satisfied()) 
   {
     char buf[22];
-    sql_print_error("Slave SQL thread stopped because it reached its"
+    sql_print_information("Slave SQL thread stopped because it reached its"
                     " UNTIL position %s", llstr(rli->until_pos(), buf));
     /* 
       Setting abort_slave flag because we do not want additional message about

--- 1.175/sql/sql_acl.cc	2006-08-23 15:37:59 -06:00
+++ 1.176/sql/sql_acl.cc	2006-08-23 15:37:59 -06:00
@@ -3669,17 +3669,11 @@ int mysql_drop_user(THD *thd, List <LEX_
   {
     if (!(acl_user= check_acl_user(user_name, &counter)))
     {
-      sql_print_error("DROP USER: Can't drop user: '%s'@'%s'; No such user",
-		      user_name->user.str,
-		      user_name->host.str);
       result= -1;
       continue;
     }
     if ((acl_user->access & ~0))
     {
-      sql_print_error("DROP USER: Can't drop user: '%s'@'%s'; Global privileges exists",
-		      user_name->user.str,
-		      user_name->host.str);
       result= -1;
       continue;
     }
@@ -3700,9 +3694,6 @@ int mysql_drop_user(THD *thd, List <LEX_
     }
     if (counter != acl_dbs.elements)
     {
-      sql_print_error("DROP USER: Can't drop user: '%s'@'%s'; Database privileges exists",
-		      user_name->user.str,
-		      user_name->host.str);
       result= -1;
       continue;
     }
@@ -3723,9 +3714,6 @@ int mysql_drop_user(THD *thd, List <LEX_
     }
     if (counter != column_priv_hash.records)
     {
-      sql_print_error("DROP USER: Can't drop user: '%s'@'%s';  Table privileges exists",
-		      user_name->user.str,
-		      user_name->host.str);
       result= -1;
       continue;
     }
@@ -3791,9 +3779,6 @@ int mysql_revoke_all(THD *thd,  List <LE
   {
     if (!check_acl_user(lex_user, &counter))
     {
-      sql_print_error("REVOKE ALL PRIVILEGES, GRANT: User '%s'@'%s' not exists",
-		      lex_user->user.str,
-		      lex_user->host.str);
       result= -1;
       continue;
     }
Thread
bk commit into 4.1 tree (tsmith:1.2536) BUG#20402tim23 Aug