MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:February 15 2010 3:33pm
Subject:Re: bzr commit into mysql-5.5-next-mr branch (mats:3045) WL#5136
View as plain text  
Hi, Mats!

On Feb 15, Mats Kindahl wrote:
> Sergei Golubchik wrote:
> > Hi, Mats!
> > 
> > On Feb 15, Mats Kindahl wrote:
> >> === modified file 'include/mysql/plugin.h'
> >> --- a/include/mysql/plugin.h	2010-01-28 00:01:26 +0000
> >> +++ b/include/mysql/plugin.h	2010-02-15 14:02:12 +0000
> >> @@ -566,6 +566,29 @@ unsigned long thd_get_thread_id(const MY
> >>  */
> >>  void thd_get_xid(const MYSQL_THD thd, MYSQL_XID *xid);
> >>  
> >> +struct scheduler_functions;
> >> +int thd_set_thread_scheduler(struct scheduler_functions *scheduler);
> >> +int thd_reset_thread_scheduler();
> > 
> > This should be a service.
> > 
> > An absolute majority of plugins will never care about these functions
> > and they should not be affected.
> 
> Hi Serg!
> 
> That was the plan, actually, but this is to get the thread pool into
> the tree as fast as possible.

Adding a service is fast. 10-15 minutes ?
See libservices/HOWTO, just follow it step by step.

Come on, you know how to do it, you were a reviewer of that feature :)

> How do you mean that plugins can be affected by adding these functions
> to the plugin.h file?

When you extend the api, you need to increase it's version. Adding new
function is a compatible change, you add 1 to the version.

Later, if this function will need to be modified - the version needs to
be changed again, to reflect that. And because there is one version
number for the whole API, changing it affects *all* plugins, no matter
whether they use scheduler function or not.

Thats's the main reason for introducing services - to have a
fine-grained control, when changing a small part of the API affects only
those plugins that use it.
 
Regards,
Sergei

Thread
bzr commit into mysql-5.5-next-mr branch (mats:3045) WL#5136Mats Kindahl15 Feb
  • Re: bzr commit into mysql-5.5-next-mr branch (mats:3045) WL#5136Sergei Golubchik15 Feb
    • Re: bzr commit into mysql-5.5-next-mr branch (mats:3045) WL#5136Mats Kindahl15 Feb
      • Re: bzr commit into mysql-5.5-next-mr branch (mats:3045) WL#5136Sergei Golubchik15 Feb
        • Re: bzr commit into mysql-5.5-next-mr branch (mats:3045) WL#5136Mats Kindahl15 Feb
          • Re: bzr commit into mysql-5.5-next-mr branch (mats:3045) WL#5136Sergei Golubchik15 Feb
            • Re: bzr commit into mysql-5.5-next-mr branch (mats:3045) WL#5136Mats Kindahl15 Feb