MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:jonas Date:August 3 2006 2:25pm
Subject:bk commit into 5.0 tree (jonas:1.2235) BUG#20296
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-08-03 16:25:47+02:00, jonas@stripped +1 -0
  ndb - bug#20296
     Make sure that tupkeyErrorLab is run if interpretedUpdate(fail), so that entry is not inserted into index.
        Yeilding crash on following dml on tupe

  ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp@stripped, 2006-08-03 16:25:46+02:00, jonas@stripped +6 -4
    Make sure that tupkeyErrorLab is run if interpretedUpdate(fail), so that entry is not inserted into index.
      Yeilding crash on following dml on tupe

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/50-work

--- 1.20/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp	2006-08-03 16:25:50 +02:00
+++ 1.21/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp	2006-08-03 16:25:50 +02:00
@@ -1113,14 +1113,16 @@
                                 regOperPtr->pageOffset,
                                 &cinBuffer[0],
                                 regOperPtr->attrinbufLen);
-    if (retValue == -1) {
-      tupkeyErrorLab(signal);
-      return -1;
-    }//if
   } else {
     jam();
     retValue = interpreterStartLab(signal, pagePtr, regOperPtr->pageOffset);
   }//if
+  
+  if (retValue == -1) {
+    tupkeyErrorLab(signal);
+    return -1;
+  }//if
+
   ndbrequire(regOperPtr->tupVersion != ZNIL);
   pagePtr->pageWord[regOperPtr->pageOffset + 1] = regOperPtr->tupVersion;
   if (regTabPtr->checksumIndicator) {
Thread
bk commit into 5.0 tree (jonas:1.2235) BUG#20296jonas3 Aug