List:Summer of Code« Previous MessageNext Message »
From:Sergei Golubchik Date:August 17 2009 7:05am
Subject:Re: GSoC Week 14 - FINAL | per query variable settings
View as plain text  
Hi, Joseph!

On Aug 16, Joseph Lukas wrote:
> KEY ACCOMPLISHMENTS LAST WEEK
> Barring review I did finish the program.
> A last minute fix did help save the program.
> All tests but backup_myisam.test work I still get an error that it cannot 
> drop a table because it is still in use.  I do not know if this is an issue 
> with my version only due to my code I do not see why it will not drop the 
> table.

ok!

> I went through and formatted as best as possible to the standards.
>
> I tried to go through the diff and find the little adjustments that are not 
> intentional and not really actual modifications such as
>
>> static bool execute_sqlcom_select(THD *thd, TABLE_LIST *all_tables)
>> {
>> @@ -6609,12 +6708,10 @@ void st_select_lex::set_lock_for_tables(
>>     operation and also for any single select union construct of the form
>>     @verbatim
>>     (SELECT ... ORDER BY order_list [LIMIT n]) ORDER BY ...
>> -    @endverbatim
>> +    @endvarbatim
>
>>     or of the form
>>     @verbatim
>>     (SELECT ... ORDER BY LIMIT n) ORDER BY ...
>> -    @endverbatim
>> -
>
> although I think i did not find the one above.  I got most of the others 
> from the other e-mail I believe.

great!

> I pushed the version to launchpad.  I had some issues since I had to pull 
> the folder off of a backup due to an error from trying to fix EXECUTE 
> command.  I deviated from the branch and had to --overwrite.  Given that me 
> an bazaar are not that friendly with each other I hope it uploaded ok.  
> Otherwise I will upload as a new branch.  If statement_set.test does not 
> work I will rebranch to the version on my machine as EXECUTE will not work.

Yes, it's ok. I had to 'bzr uncommit' a couple of times to remove
changesets that I've pulled earlier but you've overwritten. After then
'bzr pull' succeeded without a problem.

> TASKS IN THE UPCOMING WEEK
> RELAX

:)

Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
Thread
GSoC Week 14 - FINAL | per query variable settings Joseph Lukas17 Aug
  • Re: GSoC Week 14 - FINAL | per query variable settingsSergei Golubchik17 Aug