List:MySQL++« Previous MessageNext Message »
From:Warren Young Date:May 31 2014 11:21pm
Subject:Re: Connections getting "lost"/overwritten
View as plain text  
On May 31, 2014, at 7:29 AM, Quentin Armitage <quentin@stripped> wrote:

> The following code demonstrates that an established connection can be
> partially overwritten. 

Thanks for the patch!  One thing, though:

> -is_connected_(false)

...

> -	else {
> -		is_connected_ = false;
> -	}
> }

Doesn’t this pair ensure that if neither Connection object is connected, that
is_connected_ gets a random value?  Perhaps I have missed something.

Also, please follow the style you find in existing code when making a patch.  (Not just to
MySQL++.  The rule is good for all projects.)  In MySQL++, we use braces always, even when
C++ doesn’t require them.
Thread
Connections getting "lost"/overwrittenQuentin Armitage31 May 2014
  • Re: Connections getting "lost"/overwrittenWarren Young31 May 2014
    • Re: Connections getting "lost"/overwrittenQuentin Armitage1 Jun 2014
      • Re: Connections getting "lost"/overwrittenWarren Young1 Jun 2014
        • Re: Connections getting "lost"/overwritten & checking connected()Quentin Armitage3 Jun 2014
          • Re: Connections getting "lost"/overwritten & checking connected()Warren Young3 Jun 2014