From: Warren Young
Date: January 11 2010 4:14pm
Subject: Re: mysqlpp::ScopedConnection
List-Archive: http://lists.mysql.com/plusplus/8856
Message-Id: <4B4B4E67.8060202@etr-usa.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Just some nits:

> +ScopedConnection::ScopedConnection(ConnectionPool& pool)
> +: pool_(pool), connection_(pool.grab())

Whitespace.  Mentioning it just in case you contribute another ctor some 
day. :)

> +Connection*
> +ScopedConnection::operator->() const
> +{
> + return connection_;
> +}
> +
> +Connection&
> +ScopedConnection::operator*() const
> +{
> + return *connection_;
> +}

My instinct would be to put these inline in the header, so the compiler 
can optimize away the function call.  Is there a reason not to do so?

> + /// Non-copyable
> + ScopedConnection(const ScopedConnection& no_copies);

The triple-slash comments are just to get Doxygen's attention, and it 
ignores private members as we have it configured in MySQL++.

Are we giving you, personally, the copyright mention in the header 
comments, and not Switchplane?  We did with examples/for_each.cpp, but 
I'm just checking that that is still okay.