From: Kevin Regan
Date: June 23 2009 7:45pm
Subject: RE: Issue with ReconnectOption
List-Archive: http://lists.mysql.com/plusplus/8641
Message-Id: <4B18A8F75A6384449755BC7784073E9360CEF9B84F@exch11.olympus.f5net.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Any word on this?  Should the reconnect option simply be allowed before or =
after a connect?

Currently, the MySQL++ code is broken for me -- I can't set the reconnect o=
ption after the connection has been established.

--Kevin

-----Original Message-----
From: Kevin Regan [mailto:k.regan@stripped]=20
Sent: Tuesday, June 16, 2009 8:52 AM
To: plusplus@stripped
Subject: RE: Issue with ReconnectOption

No, the issue is that the current mysql++ code does not allow me (at v5.0.6=
4) to set the reconnect option after the connection is established.  This i=
s a bug that needs to be fixed for 5.0.  I added the 5.1 check to be forwar=
d looking.  However, it really is ancillary to main problem -- that the rec=
onnect flag is reset by mysql_real_connect in 5.0 (all versions below 5.1.6=
) and it needs to be set after the connection is established.

We can leave out the check for 5.1 if you are fine with folks setting this =
before and after the connection is created -- I was just trying to match wh=
at looked to be the current coding philosophy.

In any event, the current mysql++ library needs to be modified to allow set=
ting of the reconnect option after the connection has been established so t=
hat 5.0 code can work properly (for those that use this option).

Should I submit another patch that removes all checks?

--Kevin
________________________________________
From: Warren Young [mysqlpp@stripped]
Sent: Monday, June 15, 2009 9:25 AM
To: MySQL++ Mailing List
Subject: Re: Issue with ReconnectOption

Kevin Regan wrote:
> It seems that the dbd->connected() check should only be performed for
> versions of MySQL greater than 5.1.6.

Isn't that backwards?  As I read your reference manual excerpt, after
the fix in 5.1.6, you can set this option at any time, and it will be
set as expected.  It's only with the older versions, where the option
handling had the bug, where we should check for a connection before
allowing the option to be set.

See the attached patch for my take on this.

> Was this just an oversight, or
> has something changed to make this an issue?

As far as I know, this is the first change expressly made with 5.1 in
mind.  Personally, the newest version I'm using is 5.0.  I'm waiting for
some of this dust to clear before moving to a newer version.  By all
means, continue to submit 5.1 related patches, though, if that's where
your itch is.
--=20
MySQL++ Mailing List
For list archives: http://lists.mysql.com/plusplus
To unsubscribe:    http://lists.mysql.com/plusplus?unsub=3Dk.regan@stripped