List:MySQL++« Previous MessageNext Message »
From:Jim Wallace Date:October 24 2007 6:40pm
Subject:Patch for better exception use -- BadQuery w/Errnum patch part 1
View as plain text  
Part 1 of broken up new version of BadQuery update patches after review
by Warren.

In this case the BadQuery was being misused in this case and Warren
suggested a new exception.

See http://lists.mysql.com/plusplus/7060 for reference

Diffs are from the current svn

Index: result.h
===================================================================
--- result.h	(revision 1779)
+++ result.h	(working copy)
@@ -105,7 +105,7 @@
 	{
 		if (!result_) {
 			if (throw_exceptions()) {
-				throw BadQuery("Results not fetched");
+				throw UseQueryError("Results not
fetched");
 			}
 			else {
 				return Row();

Index: exceptions.h
===================================================================
--- exceptions.h	(revision 1779)
+++ exceptions.h	(working copy)
@@ -235,6 +235,19 @@
 };
 
 
+/// \brief Exception thrown no result set was returned in a fetch, 
+/// usually due to an error.
+
+class MYSQLPP_EXPORT UseQueryError : public Exception
+{
+public:
+	/// \brief Create exception object
+	explicit UseQueryError(const char* w = "") :
+	Exception(w)
+	{
+	}
+};
+
Thread
RELEASE: v2.3.2Warren Young11 Jul
  • Getting errnum() in exception?Jim Wallace20 Sep
    • Re: Getting errnum() in exception?Warren Young22 Sep
  • Building the head of SVN with MSVC?Jim Wallace25 Sep
    • Re: Building the head of SVN with MSVC?Warren Young26 Sep
  • Error num in BadQuery patchJim Wallace25 Sep
    • RE: Error num in BadQuery patchJim Wallace26 Sep
      • Re: Error num in BadQuery patchWarren Young26 Sep
    • Re: Error num in BadQuery patchWarren Young26 Sep
  • v2.3.2 and execute?Jim Wallace5 Oct
    • Re: v2.3.2 and execute?Warren Young5 Oct
  • Building svn tip on WindowsJim Wallace24 Oct
    • Re: Building svn tip on WindowsWarren Young25 Oct
  • Patch for better exception use -- BadQuery w/Errnum patch part 1Jim Wallace24 Oct
  • Better exception usage -- BadQuery w/Errnum patch part 2Jim Wallace24 Oct
  • Expose errnum() in query -- BadQuery w/Errnum patch part 3Jim Wallace24 Oct
    • Re: Expose errnum() in query -- BadQuery w/Errnum patch part 3Warren Young25 Oct
      • RE: Expose errnum() in query -- BadQuery w/Errnum patch part 3Jim Wallace25 Oct
  • BadQuery w/Errnum patch part 4Jim Wallace24 Oct
    • Re: BadQuery w/Errnum patch part 4Warren Young25 Oct
      • RE: BadQuery w/Errnum patch part 4Jim Wallace25 Oct
  • Sample files -- BadQuery w/Errnum patch part 4Jim Wallace24 Oct
    • Re: Sample files -- BadQuery w/Errnum patch part 4Warren Young25 Oct
      • RE: Sample files -- BadQuery w/Errnum patch part 4Jim Wallace25 Oct
        • Re: Sample files -- BadQuery w/Errnum patch part 4Warren Young25 Oct
          • RE: Sample files -- BadQuery w/Errnum patch part 4Jim Wallace25 Oct
          • RE: Sample files -- BadQuery w/Errnum patch part 4Jim Wallace25 Oct
            • Re: Sample files -- BadQuery w/Errnum patch part 4Warren Young25 Oct
              • RE: Sample files -- BadQuery w/Errnum patch part 4Jim Wallace25 Oct
      • RE: Sample files -- BadQuery w/Errnum patch part 4Jim Wallace25 Oct