From: Warren Young
Date: September 26 2007 8:29pm
Subject: Re: Error num in BadQuery patch
List-Archive: http://lists.mysql.com/plusplus/7061
Message-Id: <46FAC115.9010400@etr-usa.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Jim Wallace wrote:
> Some of you may have thought this was pretty bogus.

Some of us maintainers were skeptical, yes. :)

> However, what I thought was causing mysql_errno to be cleared was
> incorrect.  I thought the only API called after the error was
> mysql_error. Instead it is a successful rollback in ~Transaction that
> sets mysql_errno to zero.  

Thanks for chasing it down, and posting about it.  I'd have had to 
duplicate the work you've done to assure myself that it was useful 
before I could even think of accepting the patch.  And there's a good 
chance I wouldn't have bothered, so I'd have just rejected your patch 
entirely instead of just nit-picking it mercilessly. :)

> Here's the test case

Not necessary in this case, since it's obvious from the explanation why 
Connection::errnum() wasn't working for you.  No need to do any more 
work than necessary.