List:MySQL++« Previous MessageNext Message »
From:Matt Dargavel Date:December 22 2006 4:35pm
Subject:RE: A couple of patches
View as plain text  
Hmm, I see- no patches on the delivered message for some reason.  Here they
are inline:

README.diff:

Index: C:/Documents and Settings/Matt Dargavel/My
Documents/svn/mysqlpp/README
===================================================================
--- C:/Documents and Settings/Matt Dargavel/My Documents/svn/mysqlpp/README
(revision 1344)
+++ C:/Documents and Settings/Matt Dargavel/My Documents/svn/mysqlpp/README
(working copy)
@@ -64,6 +64,9 @@
 		which has licensing ramifications. See README.mingw
 		for details.
 
+	To get bakefile to create the makefiles necessary for each 
+	platform, simply run bakefile_gen in the project root.
+	
 
 Example Programs
 ~~~~~~~~~~~~~~~~


query.ccp.diff:

Index: C:/Documents and Settings/Matt Dargavel/My
Documents/svn/mysqlpp/lib/query.cpp
===================================================================
--- C:/Documents and Settings/Matt Dargavel/My
Documents/svn/mysqlpp/lib/query.cpp	(revision 1344)
+++ C:/Documents and Settings/Matt Dargavel/My
Documents/svn/mysqlpp/lib/query.cpp	(working copy)
@@ -31,11 +31,7 @@
 namespace mysqlpp {
 
 Query::Query(Connection* c, bool te) :
-#if defined(_MSC_VER)
-std::ostream(std::_Noinit), // prevents a double-init memory leak in RTL
-#else
-std::ostream(0),
-#endif
+std::ostream(&sbuffer_),
 OptionalExceptions(te),
 Lockable(false),
 def(this),
@@ -42,7 +38,6 @@
 conn_(c),
 success_(false)
 {
-	init(&sbuffer_);
 	success_ = true;
 }
 
@@ -47,11 +42,7 @@
 }
 
 Query::Query(const Query& q) :
-#if defined(_MSC_VER)
-std::ostream(std::_Noinit), // prevents a double-init memory leak in RTL
-#else
-std::ostream(0),
-#endif
+std::ostream(&sbuffer_),
 OptionalExceptions(q.throw_exceptions()),
 Lockable(q.locked()),
 def(q.def),
@@ -58,7 +49,6 @@
 conn_(q.conn_),
 success_(q.success_)
 {
-	init(&sbuffer_);
 }
 


> -----Original Message-----
> From: Matt Dargavel [mailto:matt@stripped]
> Sent: 22 December 2006 16:22
> To: plusplus@stripped
> Subject: RE: A couple of patches
> 
> No worries about the delay- took me long enough to get them done!  :-)
> According to my sent items the patches were there, but here's the query
> patch and README patch again.  Let me know if they don't arrive.  These
> patches are based on today's svn, although I don't think they've
> changed from the last lot.
> 
> 	Merry Christmas!
> 
> 		Matt.
> 
> 
> > -----Original Message-----
> > From: Warren Young [mailto:mysqlpp@stripped]
> > Sent: 22 December 2006 14:05
> > To: MySQL++ Mailing List
> > Subject: Re: A couple of patches
> >
> > Matt Dargavel wrote:
> > >
> > > The const_string.h one undefines min and defines NOMINMAX.  An
> > > alternative to this is to define NOMINMAX in the bakefile project
> > > creation, but this doesn't fix problems when people include
> > > const_string.h in their projects.
> > >
> > >                 The README patch adds a little extra info.
> > >
> > >                 The query.ccp patch presents the alternative
> > > solution for the memory leak, that we talked about some time ago.
> >
> > Sorry for the delay in getting back to you on this.  I just set it
> > aside for consideration, and only later realized that the patches
> > aren't actually attached.
> >
> > Don't bother with the min/max one.  I know what's going on there, and
> > am taking that up separately.
> >
> > --
> > MySQL++ Mailing List
> > For list archives: http://lists.mysql.com/plusplus
> > To unsubscribe:    http://lists.mysql.com/plusplus?unsub=1
> > telecoms.com


Thread
A couple of patchesMatt Dargavel29 Nov
  • Re: A couple of patchesWarren Young22 Dec
    • RE: A couple of patchesMatt Dargavel22 Dec
      • RE: A couple of patchesMatt Dargavel22 Dec
        • Re: A couple of patchesWarren Young22 Dec
          • Re: A couple of patchesMatt Dargavel2 Jan
            • Re: A couple of patchesWarren Young3 Jan