List:MySQL++« Previous MessageNext Message »
From:Warren Young Date:November 27 2006 11:58pm
Subject:Re: Patch to fix char signedness issue on ppc
View as plain text  
Michael Hanselmann wrote:
> 
> On Linux/ppc, gcc uses unsigned char's by default. query.cpp constructs
> an object of SQLParseElement and gives it a value of -1 for the "char"
> parameter (n). Later this value is compared to -1, which will be 255
> when using unsigned chars. The result is a wrongly thrown exception. The
> attached patch changes the type to "short int" where the number is used.

Unfortunately, that will change the ABI of the library, which would 
force this change to wait for v3.0.  Instead, why not just make the 
required signedness explicit?  Then the library interface stays the 
same, so I can apply it immediately.
Thread
Patch to fix char signedness issue on ppcMichael Hanselmann23 Nov
  • Re: Patch to fix char signedness issue on ppcOvidiu Bivolaru23 Nov
  • Re: Patch to fix char signedness issue on ppcWarren Young28 Nov
    • Re: Patch to fix char signedness issue on ppcMichael Hanselmann28 Nov
      • Re: Patch to fix char signedness issue on ppcWarren Young20 Dec