Jürgen MF Gleiss wrote:
> %(modifier)##(:name)(:) -> should be %##(modifier)(:name)(:)
True. These problems aren't big enough to force another 1.7.x release,
though, so I'm applying them to v2.0 only.
> --- mysql++-1.7.40/lib/sql_string.h 2005-05-26 11:09:32.000000000 +0200
> +++ mysql++-1.7.40_jg/lib/sql_string.h 2005-08-13 09:33:59.440083264 +0200
> @@ -116,6 +116,7 @@
> SQLString& operator =(const char* str)
> {
> std::string::operator =(str);
> + processed=false;
Please try to follow existing coding conventions! The tabs and spacing
are different here, for no good reason.
> - for ( /* */ ; (*s >= 'A' && *s <= 'Z') ||
> - *s == '_' || (*s >= 'a' && *s <= 'z'); s++) {
> + for ( /* */ ; isalnum(*s) || *s == '_' ; s++) {
No. You want isalpha() here, not is isalnum().
These changes (with corrections) will be in 2.0rc2, coming out soon.
