List:MySQL++« Previous MessageNext Message »
From:Chris Frey Date:May 10 2005 9:05pm
Subject:Re: [PATCH] Re: equal_list() using a bool vector
View as plain text  
On Tue, May 10, 2005 at 02:35:42PM -0600, Warren Young wrote:
> >plus some warning fixes for out-of-order
> >constructor arguments 
> 
> This is good to fix, but you should to do it by reordering the 
> initializer list, not by reordering the member declarations.  I don't 
> think it's an ABI breakage to make the change as you have, but it is 
> needless.

I thought that at first too, but then I noticed there were other instances
of the same type of constructor, with variables in different order.
I figured if someone else was going to wade through custom.pl, it might help
to have constructor lists in the same order, for grep reasons.


> >Index: software/mysql++/examples/custom1.cpp
> 
> I'd rather that you created a new example, rather than modify 
> custom1.cpp.  Disk space is cheap; adding custom5.cpp won't be a problem.

Agreed.


> >+			a[stock_weight] = true;
> >+			a[stock_price] = true;
> 
> I retract my wish for bare constants here.  I didn't realize that 
> custom.h defined these constants for you.  It will be good to document 
> this in an example.

Thanks to Mark for showing this in his example.  I had no idea either.


> Last but not least, can we get a DocBook comment for the new functions? 
>  I'm going to request this increasingly, so you all might as well get 
> used to it.  :)  I'm not going to have all that hard work in the new 
> docs go to waste by letting them slip back into irrelevancy.

I hope to do my share adding Doxygen comments wherever possible.  Doxygen
isn't really possible in custom.pl, as far as I know.

For DocBook, I assume straight patches to doc/userman/userman.xml are
the preferred format?  I haven't finished reading it all, so
don't feel qualified to change it yet. :-)

- Chris

Thread
equal_list() using a bool vectorMark Merendino3 May
  • Re: equal_list() using a bool vectorChris Frey4 May
  • Re: equal_list() using a bool vectorWarren Young4 May
RE: equal_list() using a bool vectorMark Merendino5 May
  • Re: equal_list() using a bool vectorWarren Young10 May
    • [PATCH] Re: equal_list() using a bool vectorChris Frey10 May
      • Re: [PATCH] Re: equal_list() using a bool vectorWarren Young10 May
        • Re: [PATCH] Re: equal_list() using a bool vectorChris Frey10 May
          • Re: [PATCH] Re: equal_list() using a bool vectorWarren Young11 May
RE: [PATCH] Re: equal_list() using a bool vectorMark Merendino11 May
  • Re: [PATCH] Re: equal_list() using a bool vectorChris Frey11 May
    • Re: [PATCH] Re: equal_list() using a bool vectorWarren Young11 May