From: Warren Young
Date: May 10 2005 8:35pm
Subject: Re: [PATCH] Re: equal_list() using a bool vector
List-Archive: http://lists.mysql.com/plusplus/4379
Message-Id: <42811B1E.1060806@etr-usa.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Chris Frey wrote:

> ... there is a template member function that has no definition in the
> rest of the header.  Specifically:

Thank you for the explanation.

> Below is Mark's patch, diff-ified, 

Thanks again.

> plus some warning fixes for out-of-order
> constructor arguments 

This is good to fix, but you should to do it by reordering the 
initializer list, not by reordering the member declarations.  I don't 
think it's an ABI breakage to make the change as you have, but it is 
needless.

> Index: software/mysql++/examples/custom1.cpp

I'd rather that you created a new example, rather than modify 
custom1.cpp.  Disk space is cheap; adding custom5.cpp won't be a problem.

> +			a[stock_weight] = true;
> +			a[stock_price] = true;

I retract my wish for bare constants here.  I didn't realize that 
custom.h defined these constants for you.  It will be good to document 
this in an example.

Last but not least, can we get a DocBook comment for the new functions? 
  I'm going to request this increasingly, so you all might as well get 
used to it.  :)  I'm not going to have all that hard work in the new 
docs go to waste by letting them slip back into irrelevancy.