List:MySQL++« Previous MessageNext Message »
From:Warren Young Date:May 10 2005 8:35pm
Subject:Re: [PATCH] Re: equal_list() using a bool vector
View as plain text  
Chris Frey wrote:

> ... there is a template member function that has no definition in the
> rest of the header.  Specifically:

Thank you for the explanation.

> Below is Mark's patch, diff-ified, 

Thanks again.

> plus some warning fixes for out-of-order
> constructor arguments 

This is good to fix, but you should to do it by reordering the 
initializer list, not by reordering the member declarations.  I don't 
think it's an ABI breakage to make the change as you have, but it is 
needless.

> Index: software/mysql++/examples/custom1.cpp

I'd rather that you created a new example, rather than modify 
custom1.cpp.  Disk space is cheap; adding custom5.cpp won't be a problem.

> +			a[stock_weight] = true;
> +			a[stock_price] = true;

I retract my wish for bare constants here.  I didn't realize that 
custom.h defined these constants for you.  It will be good to document 
this in an example.

Last but not least, can we get a DocBook comment for the new functions? 
  I'm going to request this increasingly, so you all might as well get 
used to it.  :)  I'm not going to have all that hard work in the new 
docs go to waste by letting them slip back into irrelevancy.
Thread
equal_list() using a bool vectorMark Merendino3 May
  • Re: equal_list() using a bool vectorChris Frey4 May
  • Re: equal_list() using a bool vectorWarren Young4 May
RE: equal_list() using a bool vectorMark Merendino5 May
  • Re: equal_list() using a bool vectorWarren Young10 May
    • [PATCH] Re: equal_list() using a bool vectorChris Frey10 May
      • Re: [PATCH] Re: equal_list() using a bool vectorWarren Young10 May
        • Re: [PATCH] Re: equal_list() using a bool vectorChris Frey10 May
          • Re: [PATCH] Re: equal_list() using a bool vectorWarren Young11 May
RE: [PATCH] Re: equal_list() using a bool vectorMark Merendino11 May
  • Re: [PATCH] Re: equal_list() using a bool vectorChris Frey11 May
    • Re: [PATCH] Re: equal_list() using a bool vectorWarren Young11 May