List:MySQL++« Previous MessageNext Message »
From:Chris Frey Date:September 1 2004 9:30pm
Subject:PATCH - 1.7.14 - minor cleanup
View as plain text  
Hi,

First, thanks to Warren Young for taking over maintainership of mysql++.
It was badly needed.

I've been looking through the new version and comparing it with the list
of patches I normally apply to 1.7.9, and from what I can see, there's
only a couple things missing.

I'm not sure how useful the extra virtual is on the derived
class Result, but thought I'd pass it on for consideration.

- Chris




diff -ruN mysql++-1.7.14/sqlplusint/exceptions.hh.in
mysql++-1.7.14-new/sqlplusint/exceptions.hh.in
--- mysql++-1.7.14/sqlplusint/exceptions.hh.in	2004-08-26 04:07:28.000000000 -0400
+++ mysql++-1.7.14-new/sqlplusint/exceptions.hh.in	2004-09-01 17:04:06.000000000 -0400
@@ -65,7 +65,7 @@
 #else //origional, default exception style
 
 struct BadQuery {
-  BadQuery(std::string er) : error(er) {}
+  BadQuery(std::string &er) : error(er) {}
   std::string error; //: The error message
 };
 
diff -ruN mysql++-1.7.14/sqlplusint/result1.hh mysql++-1.7.14-new/sqlplusint/result1.hh
--- mysql++-1.7.14/sqlplusint/result1.hh	2004-08-24 00:51:58.000000000 -0400
+++ mysql++-1.7.14-new/sqlplusint/result1.hh	2004-09-01 16:47:40.000000000 -0400
@@ -148,7 +148,7 @@
 // yet.
 //
 class Result : public ResUse, 
-	       public const_subscript_container<Result,Row,const Row>
+	       virtual public const_subscript_container<Result,Row,const Row>
 {
   friend class Connection;
 public:

Thread
PATCH - 1.7.14 - minor cleanupChris Frey1 Sep
  • Re: PATCH - 1.7.14 - minor cleanupWarren Young2 Sep
    • Re: PATCH - 1.7.14 - minor cleanupChris Frey2 Sep