List:Packagers« Previous MessageNext Message »
From:Christian Hammers Date:January 28 2003 12:58am
Subject:Re: [packagers] MySQL 3.23.55 is released
View as plain text  
Hi

On Mon, Jan 27, 2003 at 10:24:05PM +0200, Michael Shigorin wrote:
> Did anyone test building with perl-5.8?
It's not a perl problem it was probably just a tired developer :-)
 
> make[2]: Entering directory `/home/mike/RPM/BUILD/mysql-3.23.54/Docs'
> perl -w ./Support/generate-mirror-listing.pl manual.texi > ../MIRRORS
> [and hanging there]

Yup, the algo is basically like this:
	line: while (<>) { last line if /START/;};
	line: while (<>) { last line if /END/; do_some_thing }
No if the whole file is read without a "START", it comes to the second 
while and, oh wonder, no input. (Perls '<>' notation includes some very
black magic if you ask me, just read the eof() chapter in 'man perlfunc')

	--- Support/generate-mirror-listing.pl.orig     2003-01-28 01:48:35.000000000 +0100
	+++ Support/generate-mirror-listing.pl  2003-01-28 01:56:18.000000000 +0100
	@@ -4,8 +4,9 @@
	 
	 line: while (<>) { last line if /START_OF_MIRROR_LISTING/;};
	 
	+die("No listing found") if eof; # no parenthesis!
	+

Well in principle the whole MIRRORS file cannot generated by manual.texi
any more so the code will probably vanish from Docs/Makefile.am.

bye,

-christian-

-- 
Christian Hammers             WESTEND GmbH  |  Internet-Business-Provider
Technik                       CISCO Systems Partner - Authorized Reseller
                              Lütticher Strasse 10     Tel 0241/701333-11
ch@stripped                D-52064 Aachen              Fax 0241/911879

Thread