List:NDB Connectors« Previous MessageNext Message »
From:Monty Taylor Date:October 25 2007 1:24pm
Subject:Rev 203: Added Johan's fix for async crash. in http://bazaar.launchpad.net/~ndb-connectors/ndb-connectors/ndbjmerge
View as plain text  
At http://bazaar.launchpad.net/~ndb-connectors/ndb-connectors/ndbjmerge

------------------------------------------------------------
revno: 203
revision-id: mtaylor@stripped
parent: mtaylor@stripped
committer: Monty Taylor <mtaylor@stripped>
branch nick: ndbjmerge
timestamp: Thu 2007-10-25 06:24:04 -0700
message:
  Added Johan's fix for async crash.
modified:
  swig/ndbglobals.i              globals.i-20070228021421-qkr4cbpxymyqdrf3-7
=== modified file 'swig/ndbglobals.i'
--- a/swig/ndbglobals.i	2007-10-23 00:04:00 +0000
+++ b/swig/ndbglobals.i	2007-10-25 13:24:04 +0000
@@ -40,6 +40,9 @@
   void theNdbCallback(int ret, NdbTransaction * trans, void * anyObject) {
     BaseCallback * cb = (BaseCallback *)anyObject;
     cb->callback(ret, trans);
+    /* TODO: Fix the transaction leak here so we don't need this */
+    trans->close(); 
+    delete cb;
   }
 
   class BaseEventCallback {
@@ -129,8 +132,8 @@
 %feature("director") BaseCallback;
 
 class BaseCallback {
-  public:
   virtual ~BaseCallback() {};
+  public:
   virtual void callback(int res, NdbTransaction * trans);
   
 };

Thread
Rev 203: Added Johan's fix for async crash. in http://bazaar.launchpad.net/~ndb-connectors/ndb-connectors/ndbjmergeMonty Taylor25 Oct