You are right.
I had not looked at the current tarball.
Somehow, the offending line moved from above the curly brace to
below it during the patch application.
I'll print out the file and see if any of my other patches wandered off
after I submitted them.
Larry Rosenman wrote:
> The problem is the following else is the applied to that if, not the
> preceding if.
> Larry Rosenman
> -----Original Message-----
> From: gclark@stripped [mailto:gclark@stripped]On Behalf Of
> Gerald Clark
> Sent: Monday, August 16, 1999 9:08 AM
> To: Larry Rosenman
> Cc: mysqllist
> Subject: Re: dbf2mysql 1.12 tar ball
> Larry Rosenman wrote:
> > I was attempting to use your (I think) dbf2mysql program and found what I
> > believe to be
> > a bug.
> > around line 345 of dbf2mysql.c there is an
> > if (express) strcat(query, "NULL,NULL,");
> > outside of the braces for the preceding if. I believe
> > this needs to be within the brace.
> > What happens is the INSERT INTO TABLE %s VALUES( gets wiped out.
> > Larry Rosenman
> Why would strcat wipe out the previous contents of the query string?
> This line simply supplies the two NULL values for the fields
> "_rec and _timestamp" that will automatically be added to the resulting
> file when the -x option is used.