From: Michael Widenius
Date: March 15 1999 9:17pm
Subject: myodbc bugreport
List-Archive: http://lists.mysql.com/myodbc/35
Message-Id: <14061.30404.523213.166282@monty.pp.sci.fi>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="gEhtl7Q75X"
Content-Transfer-Encoding: 7bit

--gEhtl7Q75X
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable


Hi!

>>>>> "Manush" =3D=3D Manush Dodunekov <manush@stripped> writes:

Manush> Hi,

Manush> I just noticed two bugs in myodbc-2.50.22 (linux2.2/glibc):


Manush> * SQLColAttributes() called with SQL_COLUMN_COUNT doesn't check=
 if
stmt-> result is not null, which causes a segfault if it was.
Manush>   (line 145,results.c)

Should take care that stmt holds a valid SQL query.

Manush> * SQLGetStmtOption() with SQL_ROW_NUMBER seems to return 0-base=
d
Manush>   row numbers, when ODBC says rows start at 1
Manush>   (line 206,options.c)


Manush> Jag borde kanske skriva det h=E4r p=E5 svenska, men man vet ald=
rig =3D)

Manush> regards,
Manush> ------------------------------------------
Manush>   Manush Dodunekov / LiteCom Interactive
Manush>  manush@stripped, http://www.litecom.se
Manush> ------------------------------------------

Thanks!

Here is a patch for results.c


--gEhtl7Q75X
Content-Type: application/octet-stream
Content-Disposition: attachment;
	filename="patch"
Content-Transfer-Encoding: base64

KioqIC90bXAvcmVzdWx0cy5jCU1vbiBNYXIgMTUgMjM6MTQ6MDggMTk5OQotLS0gLi9yZXN1
bHRzLmMJTW9uIE1hciAxNSAyMzoxNzoxOSAxOTk5CioqKioqKioqKioqKioqKgoqKiogODEs
ODYgKioqKgotLS0gODEsODkgLS0tLQogIAogICAgaWYgKChlcnJvcj1jaGVja19yZXN1bHQo
c3RtdCkpICE9IFNRTF9TVUNDRVNTKQogICAgICBEQlVHX1JFVFVSTihlcnJvcik7CisgICBp
ZiAoISBzdG10LT5yZXN1bHQpCisgICAgIERCVUdfUkVUVVJOKHNldF9lcnJvcihzdG10LT5k
YmMsIjA3MDA1IiwiTm8gcmVzdWx0IHNldCIsMCkpOworIAogICAgbXlzcWxfZmllbGRfc2Vl
ayhzdG10LT5yZXN1bHQsaWNvbC0xKTsKICAgIGlmICghKGZpZWxkPW15c3FsX2ZldGNoX2Zp
ZWxkKHN0bXQtPnJlc3VsdCkpKQogICAgICBEQlVHX1JFVFVSTihzZXRfZXJyb3Ioc3RtdC0+
ZGJjLCJTMTAwMiIsIkludmFsaWQgY29sdW1uIG51bWJlciIsMCkpOwoqKioqKioqKioqKioq
KioKKioqIDEzNSwxNDAgKioqKgotLS0gMTM4LDE0NSAtLS0tCiAgCiAgICBpZiAoKGVycm9y
PWNoZWNrX3Jlc3VsdChzdG10KSkgIT0gU1FMX1NVQ0NFU1MpCiAgICAgIERCVUdfUkVUVVJO
KGVycm9yKTsKKyAgIGlmICghIHN0bXQtPnJlc3VsdCkKKyAgICAgREJVR19SRVRVUk4oc2V0
X2Vycm9yKHN0bXQtPmRiYywiMDcwMDUiLCJObyByZXN1bHQgc2V0IiwwKSk7CiAgCiAgICAv
KiBmaXJzdCBoYW5kbGUgc29tZSBzdHVwaWQgY2FzZXMgdGhhdCBkb2Vzbid0IGhhdmUgYW55
dGhpbmcgdG8gZG8KICAgICAgIHdpdGggY29sdW1ucyAqLwo=

--gEhtl7Q75X
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit


Regards,
Monty





--gEhtl7Q75X--