List:Maria Storage Engine« Previous MessageNext Message »
From:Guilhem Bichot Date:May 27 2008 9:32am
Subject:change done in mysql-test/include/ps_conv.inc
View as plain text  
Hello Monty,

I'm looking at changes we did between 5.1 and Maria. You changed
ps_conv.inc like this:
=== modified file 'mysql-test/include/ps_conv.inc'
--- mysql-test/include/ps_conv.inc	2005-08-25 03:55:48 +0000
+++ mysql-test/include/ps_conv.inc	2007-07-01 13:20:57 +0000
@@ -52,7 +52,7 @@
 set @arg14= NULL ;
 set @arg15= CAST('abc' as binary) ;
 set @arg15= NULL ;
-create table t5 as select
+eval create table t5 engine = MyISAM as select
   8                           as const01, @arg01 as param01,
   8.0                         as const02, @arg02 as param02,
   80.00000000000e-1           as const03, @arg03 as param03,

on Sun 2007-07-01 16:20:57 +0300

The comment says
"Enforce creation of table as MyISAM (to allow one to use
--default-storage-engine)"
This affects several tests, because ps_conv.inc is included in
multiple ps_* tests.
I have done similar changes myself, when the test was using
some feature which wouldn't work with Maria, like INSERT DELAYED or
MERGE tables. Here, I don't see such features used. Do you remember?
Could we remove "engine=MyISAM" ? This would increase test coverage of
--mysqld=--default-storage-engine=maria.

Thanks.

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /    Mr. Guilhem Bichot <guilhem@stripped>
 / /|_/ / // /\ \/ /_/ / /__   MySQL France, Lead Software Engineer
/_/  /_/\_, /___/\___\_\___/   Bordeaux, France
       <___/   www.mysql.com   
Thread
change done in mysql-test/include/ps_conv.incGuilhem Bichot27 May
  • re: change done in mysql-test/include/ps_conv.incMichael Widenius27 May