re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2741)

[Michael Widenius]

Hi!

>>>>> "Guilhem" == Guilhem Bichot <guilhem@stripped> writes:

Guilhem> #At bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-maria/ based on
> revid:guilhem@stripped
Guilhem>  2741 Guilhem Bichot	2009-04-01
Guilhem>       fix for simple test failures

Guilhem>     modified:
Guilhem>       mysql-test/suite/parts/r/partition_alter2_1_maria.result
Guilhem>       mysql-test/suite/parts/r/partition_alter2_2_maria.result
Guilhem>       mysql-test/suite/parts/r/partition_auto_increment_maria.result
Guilhem> === modified file 'mysql-test/suite/parts/r/partition_alter2_1_maria.result'
Guilhem> --- a/mysql-test/suite/parts/r/partition_alter2_1_maria.result	2008-11-21
> 14:21:50 +0000
Guilhem> +++ b/mysql-test/suite/parts/r/partition_alter2_1_maria.result	2009-04-01
> 10:06:41 +0000
Guilhem> @@ -3971,7 +3971,7 @@ INSERT INTO t1 (f_int1, f_int2, f_char1,
Guilhem>  SELECT f_int1, f_int1, CAST(f_int1 AS CHAR),
Guilhem>  CAST(f_int1 AS CHAR), 'delete me' FROM t0_template
Guilhem>  WHERE f_int1 IN (2,3);
Guilhem> -ERROR 23000: Can't write; duplicate key in table 't1'
Guilhem> +ERROR 23000: Duplicate entry '2-2' for key 'uidx1'

Looks like someone changed the arguments for an error message, which
is something one should *never* do!

This breaks one of the golden rules that allows one to just replace a
mysqld binary (in case of failures); With changes like this one has
also to replace the error message files.

To do this in a GA release is unheard of and the change should be
reverted immediately!

The right way to do this would be to create a new error message with
the new arguments.

I also don't understand why one delete the table name from the error
message. For many cases it's even more important than the key name.

Regards,
Monty