List:Maria Storage Engine« Previous MessageNext Message »
From:Guilhem Bichot Date:March 9 2009 9:23am
Subject:Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736)
Bug#42180
View as plain text  
Hello Monty,

Michael Widenius a écrit, Le 03/08/2009 02:49 AM:
> Hi!
> 
>>>>>> "Guilhem" == Guilhem Bichot <guilhem@stripped> writes:
> 
> Guilhem> #At bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-maria/ based on
> revid:guilhem@stripped
> Guilhem>  2736 Guilhem Bichot	2009-03-05
> Guilhem>       Fix for BUG#42180 "Maria: maria-recovery-bitmap.test fails
> repeatedly"
> Guilhem>       modified:
> Guilhem>         storage/maria/ma_loghandler.c
> Guilhem>         storage/maria/ma_test_force_start.pl
> Guilhem>         storage/maria/trnman.c
> 
> <cut>
> 
> -    if  ((undo_lsn= trn->undo_lsn) == 0) /* trn can be forgotten */
> +    if ((LSN_WITH_FLAGS_TO_FLAGS(trn->first_undo_lsn) &
> +         TRANSACTION_LOGGED_LONG_ID) == 0)
>        continue;
> 
> Another option would be to just use:
> 
> +    if (!(trn->first_undo_lsn & TRANSACTION_LOGGED_LONG_ID))

Yes, I considered this, but preferred the first way which looks less 
short-cuttish to me.

> Had no other comments on patch. Looked ok!

Thanks for looking at it.

> Can you please merge this to lp:maria also ?

You'll have to do it yourself; my revision is available at:
https://code.launchpad.net/~mysql/mysql-server/mysql-maria

Thread
bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736) Bug#42180Guilhem Bichot5 Mar
  • re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736) Bug#42180Michael Widenius8 Mar
    • Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736)Bug#42180Guilhem Bichot9 Mar
      • Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736)Bug#42180Michael Widenius9 Mar