List:Maria Storage Engine« Previous MessageNext Message »
From:Michael Widenius Date:March 8 2009 1:49am
Subject:re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736) Bug#42180
View as plain text  
Hi!

>>>>> "Guilhem" == Guilhem Bichot <guilhem@stripped> writes:

Guilhem> #At bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-maria/ based on
> revid:guilhem@stripped
Guilhem>  2736 Guilhem Bichot	2009-03-05
Guilhem>       Fix for BUG#42180 "Maria: maria-recovery-bitmap.test fails repeatedly"
Guilhem>       modified:
Guilhem>         storage/maria/ma_loghandler.c
Guilhem>         storage/maria/ma_test_force_start.pl
Guilhem>         storage/maria/trnman.c

<cut>

-    if  ((undo_lsn= trn->undo_lsn) == 0) /* trn can be forgotten */
+    if ((LSN_WITH_FLAGS_TO_FLAGS(trn->first_undo_lsn) &
+         TRANSACTION_LOGGED_LONG_ID) == 0)
       continue;

Another option would be to just use:

+    if (!(trn->first_undo_lsn & TRANSACTION_LOGGED_LONG_ID))


Had no other comments on patch. Looked ok!

Can you please merge this to lp:maria also ?

Regards,
Monty
Thread
bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736) Bug#42180Guilhem Bichot5 Mar
  • re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736) Bug#42180Michael Widenius8 Mar
    • Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736)Bug#42180Guilhem Bichot9 Mar
      • Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2736)Bug#42180Michael Widenius9 Mar