List:Maria Storage Engine« Previous MessageNext Message »
From:Magnus Svensson Date:April 22 2008 3:28pm
Subject:Re: [PATCH] mysql-test-run suites for engines (nicley)
View as plain text  
Patrick Galbraith skrev:
> I agree with this idea. Also, it'd be nice to have some way to have 
> mysql-test-run.pl be able to take an argument to use a directory 
> containing test files outside the mysql source for instances where the 
> engines aren't build within  the server tree.

You mean something like what I wrote in my previous mail? ;)

"Also made it possible to do
./mtr --suite=/some/path/to/suitedir
"


/ Magnus

> 
> On Mon, Apr 21, 2008 at 1:55 PM, Stewart Smith <stewart@stripped 
> <mailto:stewart@stripped>> wrote:
> 
>     (free row of seats on plane... extended battery... not in the right
>     timezone... so hacking at what should be 3:30am)
> 
>     Anyway.... I dislike how engines have to either put all their
>     mysql-test-run tests in the mysql-test/suite
> 
>     storage/$engine/mysql-test-suites/$suite_name/[t|r]
> 
>     e.g. PBXT may have:
> 
>     storage/pbxt/mysql-test-suites/pbxt_basic  (with t/ and r/)
>     storage/pbxt/mysql-test-suites/pbxt_advanced  (with t/ and r/)
>     storage/pbxt/mysql-test-suites/pbxt_torture  (with t/ and r/)
>     storage/pbxt/mysql-test-suites/pbxt_mtr  (with t/ and r/)
> 
>     the idea being you just plonk the storage engine in the storage/
>     directory and build the server!
> 
>     (I haven't fixed it up to install the right plugin yet... so you have to
>     have your engine built into the server). I've fixed PBXT and federatedX
>     to do this... Maria already does.
> 
>     Thoughts? (testing is welcome :)
> 
>     ===== mysql-test/lib/mtr_cases.pl 1.66 vs edited =====
>     --- 1.66/mysql-test/lib/mtr_cases.pl    2008-02-06 02:07:54 +11:00
>     +++ edited/mysql-test/lib/mtr_cases.pl  2008-04-22 03:34:58 +10:00
>     @@ -217,8 +217,15 @@
>       my $suitedir= "$::glob_mysql_test_dir"; # Default
>       if ( $suite ne "main" )
>       {
>     +    my $storagedir= "$::glob_basedir/storage";
>     +    opendir(DIR, $storagedir) || die "can't opendir $storagedir: $!";
>     +    my @se_tests = grep { /^[^\.]/ && -d
>     "$storagedir/$_/mysql-test-suites/" } readdir(DIR);
>     +    closedir DIR;
>     +    $_="$storagedir/$_/mysql-test-suites/$suite" foreach(@se_tests);
>     +    mtr_verbose("looking for suitedir in @se_tests");
>     +
>         $suitedir= mtr_path_exists("$suitedir/suite/$suite",
>     -                              "$suitedir/$suite");
>     +                              "$suitedir/$suite",@se_tests);
>         mtr_verbose("suitedir: $suitedir");
>       }
> 
> 
>     --
>     Stewart Smith, Senior Software Engineer (MySQL Cluster)
>     Sun Microsystems Inc
>     Office: +14082136540 Ext: 6616
>     VoIP: 6616@stripped <mailto:6616@stripped>
>     Mobile: +61 4 3 8844 332
> 
> 

Thread
[PATCH] mysql-test-run suites for engines (nicley)Stewart Smith22 Apr
  • Re: [PATCH] mysql-test-run suites for engines (nicley)Magnus Svensson22 Apr
Re: [PATCH] mysql-test-run suites for engines (nicley)Magnus Svensson22 Apr