List:Maria Storage Engine« Previous MessageNext Message »
From:Guilhem Bichot Date:July 11 2008 4:06pm
Subject:Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2663)
Bug#38018
View as plain text  
Hello,

On Fri, Jul 11, 2008 at 05:20:02PM +0200, Sergei Golubchik wrote:
> Hi!
> 
> On Jul 11, Guilhem Bichot wrote:
> > #At bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-maria/
> > 
> >  2663 Guilhem Bichot	2008-07-11
> >       Fix for BUG#38018 INSERT SELECT ON DUPLICATE KEY UPDATE and LOAD
> >       DATA CONCURRENT REPLACE used TL_WRITE_CONCURRENT_INSERT though
> >       they may update/delete a row. This could cause concurrent
> >       SELECTs to see a changing table while the SELECT happens, or if
> >       the query was made of a group of SELECTs, some SELECTs would see
> >       different versions of the table. And anyway versioning in Maria
> >       was so far coded to support only insertions. REPLACE SELECT,
> >       INSERT VALUES ON DUPLICATE KEY UPDATE, LOAD DATA REPLACE were
> >       ok.
> 
> Please push!

Done, in mysql-maria. Thanks for fast reply.
I have not merged it to 6.0-maria, it can be merged together with
Monty's upcoming fixes, it should be simple to merge.

Could you please run your UNION testcase with ENGINE=MARIA against
mysql-maria before and after my push, to check that it is fixed?

Thank you!

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /    Mr. Guilhem Bichot <guilhem@stripped>
 / /|_/ / // /\ \/ /_/ / /__   MySQL France, Lead Software Engineer
/_/  /_/\_, /___/\___\_\___/   Bordeaux, France
       <___/   www.mysql.com   
Thread
bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2663) Bug#38018Guilhem Bichot11 Jul
  • Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2663)Bug#38018Sergei Golubchik11 Jul
    • Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2663)Bug#38018Guilhem Bichot11 Jul