List:Maria Storage Engine« Previous MessageNext Message »
From:Guilhem Bichot Date:July 10 2008 2:55pm
Subject:Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2661)
View as plain text  
Hello,

On Thu, Jul 10, 2008 at 01:45:33PM +0200, Sergei Golubchik wrote:
> Hi!
> 
> On Jul 10, Guilhem Bichot wrote:
> > #At bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-maria/
> > 
> >  2661 Guilhem Bichot	2008-07-10
> >       Fix for bug: INSERT SELECT ON DUPLICATE KEY UPDATE and LOAD DATA
> CONCURRENT REPLACE
> >       used TL_WRITE_CONCURRENT_INSERT though they may update/delete a row.
> > modified:
> >   mysql-test/r/maria2.result
> >   mysql-test/t/maria2.test
> >   sql/sql_parse.cc
> >   storage/maria/ha_maria.cc
 
> I'm not sure I like it. It's very MyISAM-ish, and doesn't belong to
> sql_parse.cc.

Ok.
I added the same assertion to ha_myisam, and it fires the same way.
This does not tell me if it's the sign of a real bug in MyISAM too.
I filed the bug (or suspicion of) for Maria at
http://bugs.mysql.com/bug.php?id=38018

Maybe I won't be able to fix it before going on vacation tomorrow, so
I left it unassigned.

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /    Mr. Guilhem Bichot <guilhem@stripped>
 / /|_/ / // /\ \/ /_/ / /__   MySQL France, Lead Software Engineer
/_/  /_/\_, /___/\___\_\___/   Bordeaux, France
       <___/   www.mysql.com   
Thread
bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2661) Guilhem Bichot10 Jul
  • Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2661)Sergei Golubchik10 Jul
    • Re: bzr commit into MySQL/Maria:mysql-maria branch (guilhem:2661)Guilhem Bichot10 Jul