List:Internals« Previous MessageNext Message »
From:Benjamin Pflugmann Date:November 22 2002 12:07am
Subject:Re: bk commit into 3.23 tree
View as plain text  
Hi.

On Thu 2002-11-21 at 02:25:37 +0200, monty@stripped wrote:
> 
> Hi!
> 
> >>>>> "Benjamin" == Benjamin Pflugmann
> <benjamin-mysql@stripped> writes:
> <cut>
> 
> >> +++ 1.15/mysys/mf_keycache.c	Mon Nov 18 14:59:43 2002
> >> @@ -548,13 +548,14 @@
> >> count++;
> >> }
> >> /* Only allocate a new buffer if its bigger than the one we have */
> >> -      if (count <= FLUSH_CACHE ||
> >> -	  !(cache=(SEC_LINK**) my_malloc(sizeof(SEC_LINK*)*count,MYF(0))))
> >> +      if (count > FLUSH_CACHE)
> >> {
> >> -	cache=cache_buff;		/* Fall back to safe buffer */
> >> -	count=FLUSH_CACHE;
> >> +	if (!(cache=(SEC_LINK**) my_malloc(sizeof(SEC_LINK*)*count,MYF(0))))
> >> +        {
> >> +	  cache=cache_buff;		/* Fall back to safe buffer */
> >> +	  count=FLUSH_CACHE;
> >> +        }
> >> }
> >> -      end=cache+count;
> >> }
> 
> Benjamin> Sorry, if I am ignorant here, but before the change, it was assured,
> Benjamin> that
> 
> Benjamin>   count <= FLASH_CACHE
> 
> Benjamin> after this code part.

As it is written, it is nonsense of course. I am not able to reproduce
any more what I wanted to say originally.

Your explanation makes completely sense. I must have imagined another
case, which is not there. I am not sure what I was smoking. I am sorry
that I wasted your time.

Bye,

	Benjamin.

-- 
benjamin-mysql@stripped
Thread
bk commit into 3.23 treemonty18 Nov
  • Re: bk commit into 3.23 treeBenjamin Pflugmann18 Nov
    • Re: bk commit into 3.23 treeMichael Widenius21 Nov
      • Re: bk commit into 3.23 treeBenjamin Pflugmann22 Nov