List:Internals« Previous MessageNext Message »
From:Kuts Alexey Date:March 4 2013 9:59pm
Subject:inconsistency in source-code/comments in mf_keycache
View as plain text  
Hi,

I am just learning the inner working of myisam key cache
and found some inconsistency in mf_keycache.c

here is this place and my suggested patch:
--- mysys/mf_keycache.c	2011-09-07 10:08:09 +0000
+++ mysys/mf_keycache.c	2013-03-06 07:53:02 +0000
@@ -3404,7 +3404,7 @@
     return;
 
   /* Error blocks are not put into the LRU ring. */
-  if (!(block->status & BLOCK_ERROR))
+  if (block->status & BLOCK_ERROR)
   {
     /* Here the block must be in the LRU ring. Unlink it again. */
     DBUG_ASSERT(block->next_used && block->prev_used &&

I don't know, is there really a bug, that erroneous blocks are remained in LRU-ring.

Regards,
Alexey
Thread
inconsistency in source-code/comments in mf_keycacheKuts Alexey5 Mar
  • re: inconsistency in source-code/comments in mf_keycacheMichael Widenius5 Mar