List:Internals« Previous MessageNext Message »
From:Michael Widenius Date:January 25 2001 5:32pm
Subject:Re: Patches to 3.23.28
View as plain text  
Hi!


>>>>> "Albert" == Albert Chin-A-Young <china@stripped>
> writes:

Albert> On Sat, Dec 16, 2000 at 03:57:19PM +0200, Michael Widenius wrote:
>> >>>>> "Thimble" == Thimble Smith <tim@stripped> writes:
>> 
Thimble> On Tue, Dec 12, 2000 at 02:09:40PM -0600, Albert Chin-A-Young wrote:
>> >> I have uploaded a patch to:
>> >> ftp://ftp.thewrittenword.com/outgoing/pub/mysql-3.23.28.patch
>> 
Thimble> Albert, thanks for the patch.  We'll try to get it into 3.23.29.
>> 
Thimble> Tim
>> 
>> I applied the patch to MySQL 3.23.29, but after struggling with this
>> for almost 8 hours on Linux (glibc 2-1.3),
>> I had to go back to the old way of handling large files; 
>> (We are still using the rest of the patch).
>> 
>> The setting of some of the new define crashes the detection of some
>> include files (like sys/un.h).  The setting of _XOPEN_SOURCE is also a
>> very bad thing to do on Linux as it disables a lot of functionality
>> (like S_ISLNK) that we need; I did manage to go around the later
>> problem by not setting _XOPEN_SOURCE on Linux, but I couldn't find any
>> easy way to avoid the problem with sys/un.h (except patching a couple
>> of bugs in /usr/include/features.h) so I decided the old working code
>> for now.

Albert> Ok, what about this AC_SYS_LARGEFILE (from tar 1.13.19)? It does not
Albert> use _XOPEN_SOURCE.

Albert> -- 
Albert> albert chin (china@stripped)

Tim will take a look at this when he is back home.

By the way, I don't remember the real reason for changing our current
code;  It should work in all cases where the tar version works and it
has been in use in MySQL a long time already, so it should be
reasonable ok.

Regards,
Monty
Thread
Patches to 3.23.28Albert Chin-A-Young12 Dec
  • Re: Patches to 3.23.28Sinisa Milivojevic13 Dec
  • Patches to 3.23.28Michael Widenius15 Dec
  • Re: Patches to 3.23.28Thimble Smith15 Dec
    • Re: Patches to 3.23.28Michael Widenius16 Dec
      • Re: Patches to 3.23.28Albert Chin-A-Young25 Jan
        • Re: Patches to 3.23.28Michael Widenius25 Jan