List:Internals« Previous MessageNext Message »
From:Bjorn Munch Date:August 24 2012 8:45am
Subject:Re: incorrect test
View as plain text  
On 24/08 10.48, Stewart Smith wrote:
> You may notice that the tests that use the example plugin are never
> run. This is because the test in include/ is
> incorrect for mtr v2 (yes, this has been broken for a while).
> --- a/mysql-test/include/	2012-01-20 11:35:48 +0000
> +++ b/mysql-test/include/	2012-08-24 00:38:20 +0000
> @@ -8,7 +8,7 @@ if (`SELECT @@have_dynamic_loading != 'Y
>  #
>  # Check if the variable EXAMPLE_PLUGIN is set
>  #
> -if (!$EXAMPLE_PLUGIN) {
>    --skip Example plugin requires the environment variable \$EXAMPLE_PLUGIN to be set
> (normally done by mtr)

I don't understand this. If the example plugin is present, then *both*
these environment variables will be set (to non-empty).

However, in MySQL 5.1, $EXAMPLE_PLUGIN_OPT will in fact always be set
but if the example plugin is not present it will be set to
"--plugin-dir=" which is of little use. Perhaps that is what you are

In 5.5 and up they should both be set to something meaningful or they
should both be empty. But never one empty and one non-empty.

- Bjorn Munch
Thread incorrect testStewart Smith24 Aug
  • Re: incorrect testBjorn Munch24 Aug