From: Rich Prohaska
Date: August 22 2012 8:04pm
Subject: problem with TC_LOG_MMAP::commit in mysql-5.6.6-m9
List-Archive: http://lists.mysql.com/internals/38574
Message-Id: <CAB3YYRXd47qBAXz+MgjC3SNb1=LGchgg58a9QnoXSPy7gqCTsQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1

Hello,

We are porting TokuDB, a storage engine for MySQL and Mariadb that
supports XA,  to mysql-5.6.6-m9.  When committing transactions in a
MySQL system with 2 XA storage engines, TokuDB and InnoDB, we are
crashing in the TC_LOG_MMAP::log_xid function.  The
TC_LOG_MMAP::commit method is broken; it does not check the return
value from the ::log_xid method.

Here is the change that we made to fix the problem.

@@ -2631,7 +2631,7 @@
   my_xid xid= thd->transaction.xid_state.xid.get_my_xid();

   if (all && xid)
-    if ((cookie= log_xid(thd, xid)))
+    if (!(cookie= log_xid(thd, xid)))
       DBUG_RETURN(RESULT_ABORTED);    // Failed to log the transaction

   if (ha_commit_low(thd, all))


Thanks
Rich Prohaska