On 2010-09-16 10:29, Michael Widenius wrote:
>>> >> Every header file should be self-sufficient in the sense that for
> a
>>> >> header file my_header.h, the following should compile without
> errors:
>>> >>
>>> >> #include "my_header.h"
>>> >>
>>> >> An exception is made for generated files, for example, those
> generated
>>> >> by Yacc and Lex, since it is not possible to re-write the
> generators to
>>> >> produce "correct" files.
>>>
> Please consider compilation time!
>
> I just compiled MySQL on a solaris sparc box and even now it takes>
> 40 minutes. Adding self-sufficient headers will probably make this> 60
> minutes without adding any measure benefit to MySQL development.
>
> Regards,
> Monty
>
without self-contained headers, everybody has to remember to #include
stuff in the right order.
It's easy to get it wrong. I fixed several broken builds last week
because of this.
google for:
site:lists.mysql.com/commits Header files should be self-contained
-- didrik
