Re: [STYLE] use true/false in C++, not TRUE/FALSE

[Jay Pipes]

On Wed, Sep 8, 2010 at 11:36 AM, Michael Widenius <monty@stripped> wrote:
>
> Hi!
>
>>>>>> "MARK" == MARK CALLAGHAN <mdcallag@stripped> writes:
>
> <cut>
>
> MARK> That isn't the problem. The problem is when I read frequently
> MARK> undocumented header files.
> MARK> my_bool do_this();
>
> MARK> The standard used by libc and others is to return an int with 0 as
> MARK> success and != 0 as an error. MySQL is the only system on which I have
> MARK> worked that uses bool and my_bool for this.
>
> In other words, the standard is to return TRUE for errors and FALSE
> for success, which you found confusing earlier.

No.  The standard is to return 0 for success, and something other than
0 for errors.  Mark was pretty clear about that.

In all C code I've worked with, the program defines some constant such
as SUCCESS to be 0 and then non-zero returns are constants
representing error codes.  MySQL returning TRUE as 0 and FALSE as 1 is
the ONLY system I've ever seen that does that (tries to have an
unsigned char behave like C++'s bool type).  And that is why there is
a complaint that it is non-standard.

Regards,

jay