List:Internals« Previous MessageNext Message »
From:Zardosht Kasheff Date:July 24 2010 3:14am
Subject:Re: [feedback/review request] Re: index creation and concurrent reads
View as plain text  
Hello Davi,

Is ALTER_KEYS_ONOFF set if and only if alter_info->keys_onoff is
either ENABLE or DISABLE?

-Zardosht

On Fri, Jul 23, 2010 at 10:47 PM, Davi Arnaut <davi.arnaut@stripped> wrote:
> On 7/23/10 10:45 PM, Zardosht Kasheff wrote:
>>
>> Hello all,
>>
>> After some investigation, I think the attached patch solves the issue.
>> I am interested in hearing feedback on the patch.
>>
>
> How about:
>
> === modified file 'sql/sql_table.cc'
> --- sql/sql_table.cc    (foo)
> +++ sql/sql_table.cc    (bar)
> @@ -7280,7 +7280,7 @@ view_err:
>                        
>             alter_info->keys_onoff,
>                        
>             alter_info->error_if_not_empty);
>   }
> -  else
> +  else if (alter_info->flags & ALTER_KEYS_ONOFF)
>   {
>     VOID(pthread_mutex_lock(&LOCK_open));
>     wait_while_table_is_used(thd, table, HA_EXTRA_FORCE_REOPEN);
>
>
Thread
Re: [feedback/review request] Re: index creation and concurrent readsZardosht Kasheff24 Jul
  • Re: [feedback/review request] Re: index creation and concurrent readsDavi Arnaut24 Jul
    • Re: [feedback/review request] Re: index creation and concurrent readsZardosht Kasheff24 Jul
      • Re: [feedback/review request] Re: index creation and concurrent readsDavi Arnaut24 Jul
        • Re: [feedback/review request] Re: index creation and concurrent readsZardosht Kasheff24 Jul
    • Re: [feedback/review request] Re: index creation and concurrent readsZardosht Kasheff22 Oct
      • Re: [feedback/review request] Re: index creation and concurrent readsDavi Arnaut22 Oct
        • Re: [feedback/review request] Re: index creation and concurrent readsZardosht Kasheff22 Oct
          • Re: [feedback/review request] Re: index creation and concurrent readsDavi Arnaut22 Oct
            • Re: [feedback/review request] Re: index creation and concurrent readsZardosht Kasheff22 Oct
              • Re: [feedback/review request] Re: index creation and concurrentreadsSergey Vojtovich25 Oct
                • Re: [feedback/review request] Re: index creation and concurrent readsZardosht Kasheff25 Oct
                  • Re: [feedback/review request] Re: index creation and concurrentreadsSergey Vojtovich25 Oct