From: Davi Arnaut
Date: July 24 2010 2:47am
Subject: Re: [feedback/review request] Re: index creation and concurrent reads
List-Archive: http://lists.mysql.com/internals/37995
Message-Id: <4C4A545A.9020407@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 7/23/10 10:45 PM, Zardosht Kasheff wrote:
> Hello all,
>
> After some investigation, I think the attached patch solves the issue.
> I am interested in hearing feedback on the patch.
>

How about:

=== modified file 'sql/sql_table.cc'
--- sql/sql_table.cc	(foo)
+++ sql/sql_table.cc	(bar)
@@ -7280,7 +7280,7 @@ view_err:
                                      alter_info->keys_onoff,
                                      alter_info->error_if_not_empty);
    }
-  else
+  else if (alter_info->flags & ALTER_KEYS_ONOFF)
    {
      VOID(pthread_mutex_lock(&LOCK_open));
      wait_while_table_is_used(thd, table, HA_EXTRA_FORCE_REOPEN);