List:Internals« Previous MessageNext Message »
From:Guilhem Bichot Date:July 5 2010 8:30pm
Subject:Re: Fix for BUG#49129 under SCA
View as plain text  
Hello Sergey

sca@stripped a écrit, Le 05.07.2010 04:18:
> Hello,
> 
> I'd like to offer the following fix for BUG#49129 under SCA:

Thank you very much.

> @@ -3116,7 +3130,12 @@
>          JOIN_TAB *j, *jump_to= tab-1;
>          for (j= tab; j != tab + pos->n_sj_tables; j++)
>          {
> -          if (!tab->emb_sj_nest)
> +          /*
> +            NOTE: this loop probably doesn't do the right thing for the case 
> +            where FirstMatch's duplicate-generating range is interleaved with
> +            "unrelated" tables (as specified in WL#3750, section 2.2).
> +          */
> +          if (!j->emb_sj_nest)
>              jump_to= tab;
>            else
>            {
> 

The Sun guys had come through this oddity too; the latest code in their 
tree has this comment:
         if (!tab->emb_sj_nest)
           jump_to= tab;         /// @todo fix this (BUG#51457)
(the for() loop was moved elsewhere but it's irrelevant here). In 
BUG#51457 there are examples of wrong results generated by this code.

Thread
Fix for BUG#49129 under SCAsca5 Jul
  • Re: Fix for BUG#49129 under SCAManyi Lu - Sun Norway5 Jul
  • Re: Fix for BUG#49129 under SCAGuilhem Bichot5 Jul